Skip to content

Commit a3b976f

Browse files
authored
Merge pull request #374 from intersystems/fix-menu-names
fix: menu item names in VSCode/SMP
2 parents 60b8fe3 + f8befc1 commit a3b976f

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1818
- Added a new "Branch" parameter to `##class(SourceControl.Git.PullEventHandler)` (#351)
1919
- Command-line utility to do a baseline export of items in a namespace
2020

21+
### Fixed
22+
- Menu items names are properly translated from internal name in VSCode, Management Portal (#372)
2123

2224
## [2.3.1] - 2024-04-30
2325

cls/SourceControl/Git/Extension.cls

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,6 @@ Method LocalizeName(name As %String) As %String
106106

107107
Method OnSourceMenuItem(name As %String, ByRef Enabled As %String, ByRef DisplayName As %String, InternalName As %String) As %Status
108108
{
109-
110109
if name = "Settings" {
111110
set Enabled = 1
112111
quit $$$OK
@@ -159,6 +158,9 @@ Method OnSourceMenuItem(name As %String, ByRef Enabled As %String, ByRef Display
159158
} else {
160159
set Enabled = -1
161160
}
161+
if (name '= "") {
162+
set DisplayName = ..LocalizeName(name)
163+
}
162164
quit $$$OK
163165
}
164166

@@ -187,6 +189,9 @@ Method OnSourceMenuContextItem(itemName As %String, menuItemName As %String, ByR
187189
} else {
188190
set Enabled = $case(menuItemName, "AddToSC":1,:-1)
189191
}
192+
if (menuItemName '= "") {
193+
set DisplayName = ..LocalizeName(menuItemName)
194+
}
190195
quit $$$OK
191196
}
192197

0 commit comments

Comments
 (0)