Skip to content

Changed prompts in configure from 0/1 to no/yes #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 26, 2024
Merged

Changed prompts in configure from 0/1 to no/yes #494

merged 3 commits into from
Sep 26, 2024

Conversation

isc-akadoo
Copy link
Contributor

Fixes #461

isc-tleavitt
isc-tleavitt requested changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basic mode is tricky - to match the UI behavior it needs to be treated a bit differently, with 0/1/empty string as options (where empty string means "follow the system default behavior"). Using GetMenu / GetArray from %Library.Prompt would be better here.

@isc-tleavitt isc-tleavitt self-requested a review September 26, 2024 16:02
@isc-tleavitt isc-tleavitt merged commit 317c644 into main Sep 26, 2024
2 checks passed
@isc-tleavitt isc-tleavitt deleted the fix-461 branch September 26, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isc-tleavitt isc-tleavitt isc-tleavitt approved these changes

@isc-pbarton isc-pbarton Awaiting requested review from isc-pbarton

@isc-etamarch isc-etamarch Awaiting requested review from isc-etamarch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change prompts from 0/1 to no/yes
2 participants
@isc-akadoo @isc-tleavitt