Skip to content

Commit 82a5b31

Browse files
chore(item): add deprecated flag to fill prop (#28210)
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The `fill` prop on `ion-item` is currently deprecated (see warning [here](https://github.com/ionic-team/ionic-framework/blob/main/core/src/components/item/item.tsx#L248-L253)) but the docs have not been updated to reflect this. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> `@deprecated` flag added to the `fill` prop. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
1 parent b02f1af commit 82a5b31

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

core/src/components.d.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1336,6 +1336,7 @@ export namespace Components {
13361336
"download": string | undefined;
13371337
/**
13381338
* The fill for the item. If `"solid"` the item will have a background. If `"outline"` the item will be transparent with a border. Only available in `md` mode.
1339+
* @deprecated Use the `fill` property on `ion-input` or `ion-textarea` instead.
13391340
*/
13401341
"fill"?: 'outline' | 'solid';
13411342
/**
@@ -5407,6 +5408,7 @@ declare namespace LocalJSX {
54075408
"download"?: string | undefined;
54085409
/**
54095410
* The fill for the item. If `"solid"` the item will have a background. If `"outline"` the item will be transparent with a border. Only available in `md` mode.
5411+
* @deprecated Use the `fill` property on `ion-input` or `ion-textarea` instead.
54105412
*/
54115413
"fill"?: 'outline' | 'solid';
54125414
/**

core/src/components/item/item.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ export class Item implements ComponentInterface, AnchorInterface, ButtonInterfac
8585
/**
8686
* The fill for the item. If `"solid"` the item will have a background. If
8787
* `"outline"` the item will be transparent with a border. Only available in `md` mode.
88+
* @deprecated Use the `fill` property on `ion-input` or `ion-textarea` instead.
8889
*/
8990
@Prop() fill?: 'outline' | 'solid';
9091

0 commit comments

Comments
 (0)