refactor: use nextTick over setImmediate

Author: jacobheun

src/decision-engine/index.js

@@ -3,7 +3,6 @@
 const each = require('async/each')
 const eachSeries = require('async/eachSeries')
 const waterfall = require('async/waterfall')
-const setImmediate = require('async/setImmediate')
 
 const map = require('async/map')
 const debounce = require('lodash.debounce')
@@ -71,7 +70,7 @@ class DecisionEngine {
           cb()
         })
       } else {
-        setImmediate(cb)
+        process.nextTick(cb)
       }
     }, cb)
   }
@@ -179,7 +178,7 @@ class DecisionEngine {
     const ledger = this._findOrCreate(peerId)
 
     if (msg.empty) {
-      return setImmediate(cb)
+      return process.nextTick(cb)
     }
 
     // If the message was a full wantlist clear the current one
@@ -190,7 +189,7 @@ class DecisionEngine {
     this._processBlocks(msg.blocks, ledger)
 
     if (msg.wantlist.size === 0) {
-      return setImmediate(cb)
+      return process.nextTick(cb)
     }
 
     let cancels = []
@@ -294,12 +293,12 @@ class DecisionEngine {
 
   start (callback) {
     this._running = true
-    setImmediate(() => callback())
+    process.nextTick(() => callback())
   }
 
   stop (callback) {
     this._running = false
-    setImmediate(() => callback())
+    process.nextTick(() => callback())
   }
 }
 

src/index.js

@@ -4,7 +4,6 @@ const waterfall = require('async/waterfall')
 const reject = require('async/reject')
 const each = require('async/each')
 const series = require('async/series')
-const setImmediate = require('async/setImmediate')
 const map = require('async/map')
 
 const WantManager = require('./want-manager')
@@ -109,7 +108,7 @@ class Bitswap {
       (has, cb) => {
         this._updateReceiveCounters(peerId.toB58String(), block, has)
         if (has) {
-          return setImmediate(cb)
+          return process.nextTick(cb)
         }
 
         this._putBlock(block, cb)
@@ -147,7 +146,7 @@ class Bitswap {
   _putBlock (block, callback) {
     this.blockstore.put(block, (err) => {
       if (err) {
-        return setImmediate(() => callback(err))
+        return process.nextTick(() => callback(err))
       }
 
       this.notifications.hasBlock(block)
@@ -311,7 +310,7 @@ class Bitswap {
       (cb) => this.blockstore.has(block.cid, cb),
       (has, cb) => {
         if (has) {
-          return setImmediate(cb)
+          return process.nextTick(cb)
         }
 
         this._putBlock(block, cb)
@@ -334,7 +333,7 @@ class Bitswap {
       }, cb),
       (newBlocks, cb) => this.blockstore.putMany(newBlocks, (err) => {
         if (err) {
-          return setImmediate(() => cb(err))
+          return process.nextTick(() => cb(err))
         }
 
         newBlocks.forEach((block) => {
@@ -346,7 +345,7 @@ class Bitswap {
             }
           })
         })
-        setImmediate(cb)
+        process.nextTick(cb)
       })
     ], callback)
   }

src/network.js

@@ -4,7 +4,6 @@ const lp = require('pull-length-prefixed')
 const pull = require('pull-stream')
 const waterfall = require('async/waterfall')
 const each = require('async/each')
-const setImmediate = require('async/setImmediate')
 
 const Message = require('./types/message')
 const CONSTANTS = require('./constants')
@@ -44,7 +43,7 @@ class Network {
       .filter((peer) => peer.isConnected())
       .forEach((peer) => this._onPeerConnect((peer)))
 
-    setImmediate(() => callback())
+    process.nextTick(() => callback())
   }
 
   stop (callback) {
@@ -56,7 +55,7 @@ class Network {
     this.libp2p.removeListener('peer:connect', this._onPeerConnect)
     this.libp2p.removeListener('peer:disconnect', this._onPeerDisconnect)
 
-    setImmediate(() => callback())
+    process.nextTick(() => callback())
   }
 
   // Handles both types of bitswap messgages

src/types/message/index.js

@@ -139,7 +139,7 @@ BitswapMessage.deserialize = (raw, callback) => {
   try {
     decoded = pbm.Message.decode(raw)
   } catch (err) {
-    return setImmediate(() => callback(err))
+    return process.nextTick(() => callback(err))
   }
 
   const isFull = (decoded.wantlist && decoded.wantlist.full) || false
@@ -187,7 +187,7 @@ BitswapMessage.deserialize = (raw, callback) => {
   if (decoded.payload.length > 0) {
     return each(decoded.payload, (p, cb) => {
       if (!p.prefix || !p.data) {
-        return setImmediate(cb)
+        return process.nextTick(cb)
       }
       const values = vd(p.prefix)
       const cidVersion = values[0]

src/want-manager/index.js

@@ -1,7 +1,5 @@
 'use strict'
 
-const setImmediate = require('async/setImmediate')
-
 const Message = require('../types/message')
 const Wantlist = require('../types/wantlist')
 const CONSTANTS = require('../constants')
@@ -125,13 +123,13 @@ module.exports = class WantManager {
       this.peers.forEach((p) => p.addMessage(fullwantlist))
     }, 60 * 1000)
 
-    setImmediate(() => callback())
+    process.nextTick(() => callback())
   }
 
   stop (callback) {
     this.peers.forEach((mq) => this.disconnected(mq.peerId))
 
     clearInterval(this.timer)
-    setImmediate(() => callback())
+    process.nextTick(() => callback())
   }
 }