Skip to content

Commit b28fd03

Browse files
authored
fix: remove node globals and uses ipld-block (#220)
* fix: remove node globals and uses ipld-block This PR removes node globals based on the 0.27.1 released. This should be released as 0.27.2 so we can moved foward with ipld-block changes upstream without waiting on the >0.28 * fix: add ipfs utils dep
1 parent 936f899 commit b28fd03

File tree

10 files changed

+26
-24
lines changed

10 files changed

+26
-24
lines changed

package.json

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,15 @@
4343
"homepage": "https://github.com/ipfs/js-ipfs-bitswap#readme",
4444
"devDependencies": {
4545
"@nodeutils/defaults-deep": "^1.1.0",
46-
"aegir": "^20.3.1",
46+
"aegir": "^21.9.2",
4747
"async-iterator-all": "^1.0.0",
4848
"benchmark": "^2.1.4",
4949
"chai": "^4.2.0",
5050
"delay": "^4.3.0",
5151
"dirty-chai": "^2.0.1",
52-
"ipfs-repo": "^0.28.2",
52+
"ipfs-repo": "^2.1.0",
53+
"ipfs-utils": "^2.2.1",
54+
"iso-random-stream": "^1.1.1",
5355
"libp2p": "^0.27.0",
5456
"libp2p-kad-dht": "^0.18.3",
5557
"libp2p-mplex": "^0.9.2",
@@ -68,24 +70,24 @@
6870
"peer-info": "^0.17.0",
6971
"promisify-es6": "^1.0.3",
7072
"rimraf": "^3.0.0",
71-
"safe-buffer": "^5.1.2",
7273
"stats-lite": "^2.2.0",
7374
"uuid": "^3.3.2"
7475
},
7576
"dependencies": {
7677
"bignumber.js": "^9.0.0",
77-
"cids": "~0.7.0",
78+
"buffer": "^5.6.0",
79+
"cids": "~0.8.0",
7880
"debug": "^4.1.0",
79-
"ipfs-block": "~0.8.0",
81+
"ipld-block": "^0.9.1",
8082
"it-length-prefixed": "^3.0.0",
8183
"it-pipe": "^1.1.0",
8284
"just-debounce-it": "^1.1.0",
8385
"moving-average": "^1.0.0",
8486
"multicodec": "^1.0.0",
8587
"multihashing-async": "^0.8.0",
86-
"protons": "^1.0.1",
88+
"protons": "^1.2.0",
8789
"streaming-iterables": "^4.1.1",
88-
"varint-decoder": "~0.1.1"
90+
"varint-decoder": "~0.4.0"
8991
},
9092
"pre-push": [
9193
"lint",

src/types/message/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict'
22

3-
const Block = require('ipfs-block')
3+
const Block = require('ipld-block')
44
const CID = require('cids')
55
const { getName } = require('multicodec')
66
const vd = require('varint-decoder')

test/decision-engine/decision-engine.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ const PeerId = require('peer-id')
88
const range = require('lodash.range')
99
const difference = require('lodash.difference')
1010
const flatten = require('lodash.flatten')
11-
const Block = require('ipfs-block')
11+
const Block = require('ipld-block')
1212
const CID = require('cids')
1313
const multihashing = require('multihashing-async')
14-
const Buffer = require('safe-buffer').Buffer
14+
const Buffer = require('buffer').Buffer
1515

1616
const Message = require('../../src/types/message')
1717
const DecisionEngine = require('../../src/decision-engine')

test/network/gen-bitswap-network.node.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
const chai = require('chai')
66
chai.use(require('dirty-chai'))
77
const expect = chai.expect
8-
const Block = require('ipfs-block')
9-
const Buffer = require('safe-buffer').Buffer
8+
const Block = require('ipld-block')
9+
const Buffer = require('buffer').Buffer
1010
const crypto = require('crypto')
1111
const CID = require('cids')
1212
const multihashing = require('multihashing-async')

test/notifications.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ chai.use(require('dirty-chai'))
66

77
const expect = chai.expect
88
const CID = require('cids')
9-
const Block = require('ipfs-block')
9+
const Block = require('ipld-block')
1010

1111
const Notifications = require('../src/notifications')
1212

test/types/message.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ const chai = require('chai')
55
chai.use(require('dirty-chai'))
66
const expect = chai.expect
77
const CID = require('cids')
8-
const Buffer = require('safe-buffer').Buffer
8+
const Buffer = require('buffer').Buffer
99
const loadFixture = require('aegir/fixtures')
1010
const testDataPath = 'test/fixtures/serialized-from-go'
1111
const rawMessageFullWantlist = loadFixture(testDataPath + '/bitswap110-message-full-wantlist')

test/utils.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
'use strict'
33
const chai = require('chai')
44
const CID = require('cids')
5-
const Block = require('ipfs-block')
5+
const Block = require('ipld-block')
66
const { Buffer } = require('buffer')
77
const multihashing = require('multihashing-async')
88
const BitswapMessageEntry = require('../src/types/message/entry')

test/utils/make-block.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,16 @@
22

33
const multihashing = require('multihashing-async')
44
const CID = require('cids')
5-
const Block = require('ipfs-block')
6-
const crypto = require('crypto')
5+
const Block = require('ipld-block')
6+
const randomBytes = require('iso-random-stream/src/random')
77
const range = require('lodash.range')
8-
const Buffer = require('safe-buffer').Buffer
8+
const Buffer = require('buffer').Buffer
99
const uuid = require('uuid/v4')
1010

1111
module.exports = async (count, size) => {
1212
const blocks = await Promise.all(
1313
range(count || 1).map(async () => {
14-
const data = size ? crypto.randomBytes(size) : Buffer.from(`hello world ${uuid()}`)
14+
const data = size ? randomBytes(size) : Buffer.from(`hello world ${uuid()}`)
1515
const hash = await multihashing(data, 'sha2-256')
1616
return new Block(data, new CID(hash))
1717
})

test/utils/mocks.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ const PeerId = require('peer-id')
55
const PeerInfo = require('peer-info')
66
const PeerStore = require('libp2p/src/peer-store')
77
const Node = require('./create-libp2p-node').bundle
8-
const os = require('os')
8+
const tmpdir = require('ipfs-utils/src/temp-dir')
99
const Repo = require('ipfs-repo')
1010
const EventEmitter = require('events')
1111

@@ -56,14 +56,14 @@ exports.mockNetwork = (calls, done) => {
5656

5757
return {
5858
connectTo (p) {
59-
setImmediate(() => {
59+
setTimeout(() => {
6060
connects.push(p)
6161
})
6262
},
6363
sendMessage (p, msg) {
6464
messages.push([p, msg])
6565

66-
setImmediate(() => {
66+
setTimeout(() => {
6767
finish()
6868
})
6969

@@ -176,7 +176,7 @@ exports.genBitswapNetwork = async (n, enableDHT = false) => {
176176
})
177177

178178
// create the repos
179-
const tmpDir = os.tmpdir()
179+
const tmpDir = tmpdir()
180180
netArray.forEach((net, i) => {
181181
const repoPath = tmpDir + '/' + net.peerInfo.id.toB58String()
182182
net.repo = new Repo(repoPath)

test/wantmanager/msg-queue.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const expect = chai.expect
77
const PeerId = require('peer-id')
88
const CID = require('cids')
99
const multihashing = require('multihashing-async')
10-
const Buffer = require('safe-buffer').Buffer
10+
const Buffer = require('buffer').Buffer
1111
const Message = require('../../src/types/message')
1212
const MsgQueue = require('../../src/want-manager/msg-queue')
1313

0 commit comments

Comments
 (0)