fix: reduce bundle size

BREAKING CHANGE: change from big.js to bignumber.js

The impact of this change is only on the `snapshot` field of
the stats, as those values are represented as Big Numbers.

Author: hugomrdias

README.md

@@ -93,7 +93,7 @@ const snapshot = stats.snapshot
 console.log('stats: %j', snapshot)
 ```
 
-the snapshot will contain the following keys, with the values being [Big.js](https://github.com/MikeMcl/big.js#readme) instances:
+the snapshot will contain the following keys, with the values being [bignumber.js](https://github.com/MikeMcl/bignumber.js#readme) instances:
 
 ```js
 // stats: {

package.json

@@ -43,7 +43,7 @@
   "homepage": "https://github.com/ipfs/js-ipfs-bitswap#readme",
   "devDependencies": {
     "@nodeutils/defaults-deep": "^1.1.0",
-    "aegir": "^17.1.1",
+    "aegir": "^18.0.2",
     "benchmark": "^2.1.4",
     "chai": "^4.2.0",
     "dirty-chai": "^2.0.1",
@@ -56,36 +56,28 @@
     "lodash": "^4.17.11",
     "lodash.range": "^3.2.0",
     "lodash.without": "^4.4.0",
-    "multiaddr": "^6.0.0",
     "ncp": "^2.0.0",
     "peer-book": "~0.9.0",
     "peer-id": "~0.12.0",
     "peer-info": "~0.15.0",
     "rimraf": "^2.6.2",
-    "stats-lite": "^2.2.0"
+    "stats-lite": "^2.2.0",
+    "safe-buffer": "^5.1.2",
+    "uuid": "^3.3.2"
   },
   "dependencies": {
     "async": "^2.6.1",
-    "big.js": "^5.2.2",
+    "bignumber.js": "^8.0.1",
     "cids": "~0.5.5",
     "debug": "^4.1.0",
     "ipfs-block": "~0.8.0",
-    "lodash.debounce": "^4.0.8",
-    "lodash.find": "^4.6.0",
-    "lodash.groupby": "^4.6.0",
+    "just-debounce-it": "^1.1.0",
     "lodash.isequalwith": "^4.4.0",
-    "lodash.isundefined": "^3.0.1",
-    "lodash.pullallwith": "^4.7.0",
-    "lodash.sortby": "^4.7.0",
-    "lodash.uniqwith": "^4.5.0",
-    "lodash.values": "^4.3.0",
     "moving-average": "^1.0.0",
     "multicodec": "~0.2.7",
     "multihashing-async": "~0.5.1",
     "protons": "^1.0.1",
-    "pull-defer": "~0.2.3",
     "pull-length-prefixed": "^1.3.1",
-    "pull-pushable": "^2.2.0",
     "pull-stream": "^3.6.9",
     "varint-decoder": "~0.1.1"
   },

src/decision-engine/index.js

@@ -6,17 +6,12 @@ const waterfall = require('async/waterfall')
 const nextTick = require('async/nextTick')
 
 const map = require('async/map')
-const debounce = require('lodash.debounce')
-const uniqWith = require('lodash.uniqwith')
-const find = require('lodash.find')
-const values = require('lodash.values')
-const groupBy = require('lodash.groupby')
-const pullAllWith = require('lodash.pullallwith')
+const debounce = require('just-debounce-it')
 
 const Message = require('../types/message')
 const Wantlist = require('../types/wantlist')
 const Ledger = require('./ledger')
-const logger = require('../utils').logger
+const { logger, groupBy, pullAllWith, uniqWith } = require('../utils')
 
 const MAX_MESSAGE_SIZE = 512 * 1024
 
@@ -92,18 +87,18 @@ class DecisionEngine {
     this._tasks = []
     const entries = tasks.map((t) => t.entry)
     const cids = entries.map((e) => e.cid)
-    const uniqCids = uniqWith(cids, (a, b) => a.equals(b))
-    const groupedTasks = groupBy(tasks, (task) => task.target.toB58String())
+    const uniqCids = uniqWith((a, b) => a.equals(b), cids)
+    const groupedTasks = groupBy(task => task.target.toB58String(), tasks)
 
     waterfall([
       (callback) => map(uniqCids, (cid, cb) => {
         this.blockstore.get(cid, cb)
       }, callback),
-      (blocks, callback) => each(values(groupedTasks), (tasks, cb) => {
+      (blocks, callback) => each(Object.values(groupedTasks), (tasks, cb) => {
         // all tasks have the same target
         const peer = tasks[0].target
         const blockList = cids.map((cid) => {
-          return find(blocks, (b) => b.cid.equals(cid))
+          return blocks.find(b => b.cid.equals(cid))
         })
 
         this._sendBlocks(peer, blockList, (err) => {
@@ -212,11 +207,11 @@ class DecisionEngine {
   _cancelWants (ledger, peerId, entries) {
     const id = peerId.toB58String()
 
-    pullAllWith(this._tasks, entries, (t, e) => {
+    this._tasks = pullAllWith((t, e) => {
       const sameTarget = t.target.toB58String() === id
       const sameCid = t.entry.cid.equals(e.cid)
       return sameTarget && sameCid
-    })
+    }, this._tasks, entries)
   }
 
   _addWants (ledger, peerId, entries, callback) {

src/stats/stat.js

@@ -1,7 +1,7 @@
 'use strict'
 
 const EventEmitter = require('events')
-const Big = require('big.js')
+const Big = require('bignumber.js')
 const MovingAverage = require('moving-average')
 
 class Stats extends EventEmitter {

src/types/wantlist/index.js

@@ -1,6 +1,6 @@
 'use strict'
 
-const sort = require('lodash.sortby')
+const { sortBy } = require('../../utils')
 const Entry = require('./entry')
 
 class Wantlist {
@@ -64,11 +64,7 @@ class Wantlist {
   }
 
   sortedEntries () {
-    return new Map(
-      sort(Array.from(this.set.entries()), (o) => {
-        return o[1].key
-      })
-    )
+    return new Map(sortBy(o => o[1].key, Array.from(this.set.entries())))
   }
 
   contains (cid) {

src/utils.js

@@ -11,7 +11,7 @@ const debug = require('debug')
  *
  * @private
  */
-exports.logger = (id, subsystem) => {
+const logger = (id, subsystem) => {
   const name = ['bitswap']
   if (subsystem) {
     name.push(subsystem)
@@ -24,3 +24,67 @@ exports.logger = (id, subsystem) => {
 
   return logger
 }
+
+const includesWith = (pred, x, list) => {
+  let idx = 0
+  const len = list.length
+  while (idx < len) {
+    if (pred(x, list[idx])) {
+      return true
+    }
+    idx += 1
+  }
+  return false
+}
+
+const uniqWith = (pred, list) => {
+  let idx = 0
+  const len = list.length
+  const result = []
+  let item
+
+  while (idx < len) {
+    item = list[idx]
+    if (!includesWith(pred, item, result)) {
+      result[result.length] = item
+    }
+    idx += 1
+  }
+  return result
+}
+
+const groupBy = (pred, list) => {
+  return list.reduce((acc, v) => {
+    const k = pred(v)
+
+    if (acc[k]) {
+      acc[k].push(v)
+    } else {
+      acc[k] = [v]
+    }
+    return acc
+  }, {})
+}
+
+const pullAllWith = (pred, list, values) => {
+  return list.filter(i => {
+    return !includesWith(pred, i, values)
+  })
+}
+
+const sortBy = (fn, list) => {
+  return Array.prototype.slice.call(list, 0).sort((a, b) => {
+    const aa = fn(a)
+    const bb = fn(b)
+    return aa < bb ? -1 : aa > bb ? 1 : 0
+  })
+}
+
+module.exports = {
+  logger,
+  includesWith,
+  uniqWith,
+  groupBy,
+  pullAllWith,
+  sortBy
+}

src/want-manager/msg-queue.js

@@ -1,6 +1,6 @@
 'use strict'
 
-const debounce = require('lodash.debounce')
+const debounce = require('just-debounce-it')
 
 const Message = require('../types/message')
 const logger = require('../utils').logger

test/utils.spec.js

@@ -0,0 +1,111 @@
+/* eslint-env mocha */
+'use strict'
+const chai = require('chai')
+chai.use(require('dirty-chai'))
+const expect = chai.expect
+const { groupBy, uniqWith, pullAllWith, includesWith, sortBy } = require('../src/utils')
+
+describe('utils spec', function () {
+  it('grouby', (done) => {
+    const list = [
+      { name: 'name1', score: 1 },
+      { name: 'name2', score: 1 },
+      { name: 'name3', score: 2 }
+    ]
+    const actual = groupBy(p => p.score === 1 ? 'a' : 'b', list)
+
+    expect(actual).to.deep.equal({
+      a: [
+        { name: 'name1', score: 1 },
+        { name: 'name2', score: 1 }
+      ],
+      b: [{ name: 'name3', score: 2 }]
+    })
+
+    done()
+  })
+
+  it('pullAllWith', (done) => {
+    var array = [{ x: 1, y: 2 }, { x: 3, y: 4 }, { x: 5, y: 6 }]
+
+    const actual = pullAllWith(
+      (a, b) => (a.x === b.x && a.y === b.y),
+      array,
+      [{ x: 3, y: 4 }]
+    )
+
+    expect(actual).to.deep.equal([{ x: 1, y: 2 }, { x: 5, y: 6 }])
+
+    done()
+  })
+
+  it('uniqWith', (done) => {
+    class T {
+      constructor (id) {
+        this.id = id
+      }
+
+      equals (instance) {
+        return instance.id === this.id
+      }
+    }
+    const list = [new T(1), new T(1), new T(2)]
+
+    const r = uniqWith((a, b) => a.equals(b), list)
+
+    if (r[0].id === 1 && r[1].id === 2) {
+      return done()
+    }
+
+    return done(new Error('no match'))
+  })
+
+  it('includesWith', (done) => {
+    class T {
+      constructor (id) {
+        this.id = id
+      }
+
+      equals (instance) {
+        return instance.id === this.id
+      }
+    }
+    const list = [new T(1), new T(2), new T(3)]
+
+    const r1 = includesWith((a, b) => a.equals(b), new T(2), list)
+    const r2 = includesWith((a, b) => a.equals(b), new T(4), list)
+    expect(r1).to.be.true()
+    expect(r2).to.be.false()
+
+    done()
+  })
+
+  it('sortBy', (done) => {
+    const list = [
+      {
+        id: 3,
+        name: 'b'
+      },
+      {
+        id: 2,
+        name: 'a'
+      },
+      {
+        id: 1,
+        name: 'c'
+      }
+    ]
+
+    const groupedList1 = sortBy(o => o.name, list)
+    const groupedList2 = sortBy(o => o.id, list)
+
+    expect(groupedList1).to.be.deep.equal([ { id: 2, name: 'a' },
+      { id: 3, name: 'b' },
+      { id: 1, name: 'c' } ])
+    expect(groupedList2).to.be.deep.equal([ { id: 1, name: 'c' },
+      { id: 2, name: 'a' },
+      { id: 3, name: 'b' } ])
+
+    done()
+  })
+})