Don't select closed/closing connections in the pool (#417)

davidmartos96 · web-flow · commit 31df6ab47896 · 2025-02-21T15:16:13.000+01:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## 3.5.3
 
 - New typed exceptions: `UniqueViolationException`, `ForeignKeyViolationException`. [#416](https://github.com/isoos/postgresql-dart/pull/416) by [hurrba](https://github.com/hurrba)
+- Fix: don't reuse pool connections that are closed/closing. [#417](https://github.com/isoos/postgresql-dart/pull/417) by [davidmartos96](https://github.com/davidmartos96)
 
 ## 3.5.2
 
diff --git a/lib/src/pool/pool_impl.dart b/lib/src/pool/pool_impl.dart
@@ -232,7 +232,7 @@ class _PoolConnection implements Connection {
       this._pool, this._endpoint, this._connectionSettings, this._connection);
 
   bool _mayReuse(Endpoint endpoint, ResolvedConnectionSettings settings) {
-    if (_isInUse || endpoint != _endpoint || _isExpired()) {
+    if (_isInUse || endpoint != _endpoint || _isExpired() || !isOpen) {
       return false;
     }
     if (!_connectionSettings.isMatchingConnection(settings)) {

Original file line number	Diff line number	Diff line change
`@@ -232,7 +232,7 @@ class _PoolConnection implements Connection {`
`232`	`232`	`this._pool, this._endpoint, this._connectionSettings, this._connection);`
`233`	`233`
`234`	`234`	`bool _mayReuse(Endpoint endpoint, ResolvedConnectionSettings settings) {`
`235`		`- if (_isInUse \|\| endpoint != _endpoint \|\| _isExpired()) {`
	`235`	`+ if (_isInUse \|\| endpoint != _endpoint \|\| _isExpired() \|\| !isOpen) {`
`236`	`236`	`return false;`
`237`	`237`	`}`
`238`	`238`	`if (!_connectionSettings.isMatchingConnection(settings)) {`