Update tests

Author: jakebailey

scripts/eslint/rules/argument-trivia.cjs

@@ -28,9 +28,9 @@ module.exports = createRule({
             recommended: "error",
         },
         messages: {
-            parameterTriviaArgumentError: `Tag argument with parameter name`,
-            parameterTriviaArgumentSpaceError: `There should be 1 space between an argument and its comment`,
-            parameterTriviaArgumentNameError: `Argument name "{{ got }}" does not match expected name "{{ want }}"`,
+            argumentTriviaArgumentError: `Tag argument with parameter name`,
+            argumentTriviaArgumentSpaceError: `There should be 1 space between an argument and its comment`,
+            argumentTriviaArgumentNameError: `Argument name "{{ got }}" does not match expected name "{{ want }}"`,
         },
         schema: [],
         type: "problem",
@@ -111,15 +111,15 @@ module.exports = createRule({
                 const expectedName = getExpectedName();
                 if (expectedName) {
                     context.report({
-                        messageId: "parameterTriviaArgumentError",
+                        messageId: "argumentTriviaArgumentError",
                         node,
                         fix: (fixer) => {
                             return fixer.insertTextBefore(node, `/*${expectedName}*/ `);
                         }
                     });
                 }
                 else {
-                    context.report({ messageId: "parameterTriviaArgumentError", node });
+                    context.report({ messageId: "argumentTriviaArgumentError", node });
                 }
                 return;
             }
@@ -136,7 +136,7 @@ module.exports = createRule({
 
                 if (got !== expectedName) {
                     context.report({
-                        messageId: "parameterTriviaArgumentNameError",
+                        messageId: "argumentTriviaArgumentNameError",
                         data: { got, want: expectedName },
                         node: comment,
                         fix: (fixer) => {
@@ -151,7 +151,7 @@ module.exports = createRule({
             if (argRangeStart !== commentRangeEnd + 1 && !hasNewLine) {
                 // TODO(jakebailey): range should be whitespace
                 context.report({
-                    messageId: "parameterTriviaArgumentSpaceError",
+                    messageId: "argumentTriviaArgumentSpaceError",
                     node,
                     fix: (fixer) => {
                         return fixer.replaceTextRange([commentRangeEnd, argRangeStart], " ");
@@ -161,7 +161,7 @@ module.exports = createRule({
         };
 
         /** @type {(node: TSESTree.CallExpression | TSESTree.NewExpression) => void} */
-        const checkparameterTrivia = (node) => {
+        const checkargumentTrivia = (node) => {
             if (shouldIgnoreCalledExpression(node)) {
                 return;
             }
@@ -183,8 +183,8 @@ module.exports = createRule({
         };
 
         return {
-            CallExpression: checkparameterTrivia,
-            NewExpression: checkparameterTrivia,
+            CallExpression: checkargumentTrivia,
+            NewExpression: checkargumentTrivia,
         };
     },
 });

scripts/eslint/tests/argument-trivia.test.cjs

@@ -48,6 +48,12 @@ const fn = (prop: boolean) => {};
 fn.apply(null, true);
         `,
         },
+        {
+            code: `
+const fn = (prop: boolean) => {};
+fn(/* first comment */ /* second comment */ false);
+            `,
+        },
     ],
 
     invalid: [
@@ -56,28 +62,25 @@ fn.apply(null, true);
 const fn = (prop: null) => {};
 fn(null);
             `,
-            errors: [{ messageId: "parameterTriviaArgumentError" }],
+            errors: [{ messageId: "argumentTriviaArgumentError" }],
         },
         {
             code: `
 const fn = (prop: boolean) => {};
 fn(false);
             `,
-            errors: [{ messageId: "parameterTriviaArgumentError" }],
+            errors: [{ messageId: "argumentTriviaArgumentError" }],
         },
         {
             code: `
 const fn = (prop: boolean) => {};
 fn(/* boolean arg */false);
             `,
-            errors: [{ messageId: "parameterTriviaArgumentSpaceError" }],
-        },
-        {
-            code: `
+            errors: [{ messageId: "argumentTriviaArgumentSpaceError" }],
+            output:`
 const fn = (prop: boolean) => {};
-fn(/* first comment */ /* second comment */ false);
-            `,
-            errors: [{ messageId: "parameterTriviaArgumentError" }],
+fn(/* boolean arg */ false);
+            `
         },
     ],
 });