[Object] Avoid repeated hash lookups (NFC) (llvm#127746)

kazutakahirata · web-flow · commit 1bb72f0d7dd6 · 2025-02-19T08:21:10.000-08:00
diff --git a/llvm/lib/Object/GOFFObjectFile.cpp b/llvm/lib/Object/GOFFObjectFile.cpp
@@ -503,8 +503,9 @@ GOFFObjectFile::getSectionContents(DataRefImpl Sec) const {
     std::copy(CompleteData.data(), CompleteData.data() + TxtDataSize,
               Data.begin() + TxtDataOffset);
   }
-  SectionDataCache[Sec.d.a] = Data;
-  return ArrayRef<uint8_t>(SectionDataCache[Sec.d.a]);
+  auto &Cache = SectionDataCache[Sec.d.a];
+  Cache = Data;
+  return ArrayRef<uint8_t>(Cache);
 }
 
 uint64_t GOFFObjectFile::getSectionAlignment(DataRefImpl Sec) const {

Original file line number	Diff line number	Diff line change
`@@ -503,8 +503,9 @@ GOFFObjectFile::getSectionContents(DataRefImpl Sec) const {`
`503`	`503`	`std::copy(CompleteData.data(), CompleteData.data() + TxtDataSize,`
`504`	`504`	`Data.begin() + TxtDataOffset);`
`505`	`505`	`}`
`506`		`- SectionDataCache[Sec.d.a] = Data;`
`507`		`- return ArrayRef<uint8_t>(SectionDataCache[Sec.d.a]);`
	`506`	`+ auto &Cache = SectionDataCache[Sec.d.a];`
	`507`	`+ Cache = Data;`
	`508`	`+ return ArrayRef<uint8_t>(Cache);`
`508`	`509`	`}`
`509`	`510`
`510`	`511`	`uint64_t GOFFObjectFile::getSectionAlignment(DataRefImpl Sec) const {`