fix misplacing points in position_dodge2 (tidyverse#4936)

javlon · web-flow · commit d54fd69da454 · 2022-08-11T22:43:51.000+09:00
Fixes bug which misplaced geom objects when it had zero width.
diff --git a/R/position-dodge2.r b/R/position-dodge2.r
@@ -138,7 +138,7 @@ find_x_overlaps <- function(df) {
   overlaps[1] <- counter <- 1
 
   for (i in seq_asc(2, nrow(df))) {
-    if (is.na(df$xmin[i]) || is.na(df$xmax[i - 1]) || df$xmin[i] >= df$xmax[i - 1]) {
+    if (is.na(df$xmin[i]) || is.na(df$xmax[i - 1]) || df$xmin[i] > df$xmax[i - 1]) {
       counter <- counter + 1
     }
     overlaps[i] <- counter

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ find_x_overlaps <- function(df) {`
`138`	`138`	`overlaps[1] <- counter <- 1`
`139`	`139`
`140`	`140`	`for (i in seq_asc(2, nrow(df))) {`
`141`		`- if (is.na(df$xmin[i]) \|\| is.na(df$xmax[i - 1]) \|\| df$xmin[i] >= df$xmax[i - 1]) {`
	`141`	`+ if (is.na(df$xmin[i]) \|\| is.na(df$xmax[i - 1]) \|\| df$xmin[i] > df$xmax[i - 1]) {`
`142`	`142`	`counter <- counter + 1`
`143`	`143`	`}`
`144`	`144`	`overlaps[i] <- counter`