[Backport generator] Remove work-around for package spelling

usiems · jcfr · commit e68762281d57 · 2024-01-28T18:06:44.000-05:00
by putting the correct spelling in the package name in the typesystem files (cherry picked from commit MeVisLab/pythonqt@182df8d)
diff --git a/generator/setupgenerator.cpp b/generator/setupgenerator.cpp
@@ -52,10 +52,6 @@ void SetupGenerator::addClass(const QString& package, const AbstractMetaClass *c
   packHash[package].append(cls);
 }
 
-void maybeDeclareMetaType(QTextStream &stream, const QString &typeName,
-                          QSet<QString> &registeredTypeNames);
-bool hasDefaultConstructor(const AbstractMetaClass *meta_class);
-
 static QStringList getOperatorCodes(const AbstractMetaClass* cls) {
   QSet<QString> operatorCodes;
   AbstractMetaFunctionList returned;
@@ -247,34 +243,11 @@ void SetupGenerator::generate()
       continue;
     std::stable_sort(list.begin(), list.end(), AbstractMetaClass::less_than);
 
-    QString packKey = pack.key();
-    QString packName = pack.key();
-    QStringList components = packName.split("_");
-    if ((components.size() > 2) && (components.at(0) == "com")
-      && (components.at(1) == "trolltech")) {
-        // kill com.trolltech in key
-        components.removeAt(0);
-        components.removeAt(0);
-    }
-
-    QString shortPackName;
-    foreach (QString comp, components) {
-      comp[0] = comp[0].toUpper();
-      shortPackName += comp;
-    }
-    // add missing camel case (workaround..)
-    if (shortPackName == "QtWebkit") {
-      shortPackName = "QtWebKit";
-    } else if (shortPackName == "QtXmlpatterns") {
-      shortPackName = "QtXmlPatterns";
-    } else if (shortPackName == "QtWebenginewidgets") {
-      shortPackName = "QtWebEngineWidgets";
-    } else if (shortPackName == "QtOpengl") {
-      shortPackName = "QtOpenGL";
-    } else if (shortPackName == "QtUitools") {
-      shortPackName = "QtUiTools";
-    }
-
+    QString packKey = ShellGenerator::toFileNameBase(pack.key());
+    QString packName = packKey;
+    QString qtPackageName = "Qt" + pack.key().split('.').back().split('_').front();
+    bool isBuiltin = packKey.endsWith("_builtin");
+    QString initName = qtPackageName + (isBuiltin ? "Builtin" : "");
 
     {
       QString fileName(packName + "/" + packKey + "_init.cpp");
@@ -291,7 +264,7 @@ void SetupGenerator::generate()
       s << endl;
 
       QStringList polymorphicHandlers;
-      if (!packName.endsWith("_builtin")) {
+      if (!isBuiltin) {
         polymorphicHandlers = writePolymorphicHandler(s, list.at(0)->package(), classes_with_polymorphic_id, list);
         s << endl;
       }
@@ -328,11 +301,7 @@ void SetupGenerator::generate()
       s << endl;
 
       // declare individual class creation functions
-      s << "void PythonQt_init_" << shortPackName << "(PyObject* module) {" << endl;
-
-      if (shortPackName.endsWith("Builtin")) {
-        shortPackName = shortPackName.mid(0, shortPackName.length()-strlen("builtin"));
-      }
+      s << "void PythonQt_init_" << initName << "(PyObject* module) {" << endl;
 
       foreach (const AbstractMetaClass *cls, list) {
         if (cls->qualifiedCppName().contains("Ssl")) {
@@ -367,10 +336,10 @@ void SetupGenerator::generate()
           operatorCodes = "0";
         }
         if (cls->isQObject()) {
-          s << "PythonQt::priv()->registerClass(&" << cls->qualifiedCppName() << "::staticMetaObject, \"" << shortPackName <<"\", PythonQtCreateObject<PythonQtWrapper_" << cls->name() << ">" << shellCreator << ", module, " << operatorCodes <<");" << endl;
+          s << "PythonQt::priv()->registerClass(&" << cls->qualifiedCppName() << "::staticMetaObject, \"" << qtPackageName <<"\", PythonQtCreateObject<PythonQtWrapper_" << cls->name() << ">" << shellCreator << ", module, " << operatorCodes <<");" << endl;
         } else {
           QString baseName = cls->baseClass()?cls->baseClass()->qualifiedCppName():"";
-          s << "PythonQt::priv()->registerCPPClass(\""<< cls->qualifiedCppName() << "\", \"" << baseName << "\", \"" << shortPackName <<"\", PythonQtCreateObject<PythonQtWrapper_" << cls->name() << ">" << shellCreator << ", module, " << operatorCodes <<");" << endl;
+          s << "PythonQt::priv()->registerCPPClass(\""<< cls->qualifiedCppName() << "\", \"" << baseName << "\", \"" << qtPackageName <<"\", PythonQtCreateObject<PythonQtWrapper_" << cls->name() << ">" << shellCreator << ", module, " << operatorCodes <<");" << endl;
         }
         for (AbstractMetaClass* interface :  cls->interfaces()) {
           // the interface might be our own class... (e.g. QPaintDevice)
diff --git a/generator/shellgenerator.h b/generator/shellgenerator.h
@@ -53,7 +53,7 @@ class ShellGenerator : public Generator
 public:
     virtual QString subDirectoryForClass(const AbstractMetaClass *cls) const
     {
-        return "generated_cpp/" + cls->package().replace(".", "_") + "/";
+        return "generated_cpp/" + toFileNameBase(cls->package()) + "/";
     }
 
     void writeTypeInfo(QTextStream &s, const AbstractMetaType *type, Option option = NoOption, TypeSystem::Ownership ownership = TypeSystem::InvalidOwnership);
@@ -95,7 +95,9 @@ class ShellGenerator : public Generator
     static bool isBuiltIn(const QString& name);
 
     static bool isSpecialStreamingOperator(const AbstractMetaFunction *fun);
-    
+
+    static QString toFileNameBase(QString packageName) { return packageName.replace('.', '_').toLower(); }
+
     static void writeInclude(QTextStream &stream, const Include &inc);
   
     // this scope is used in writeFunctionArguments
diff --git a/generator/shellheadergenerator.cpp b/generator/shellheadergenerator.cpp
@@ -102,9 +102,10 @@ void ShellHeaderGenerator::write(QTextStream& s, const AbstractMetaClass* meta_c
 {
   setCurrentScope(meta_class);
   QString builtIn = ShellGenerator::isBuiltIn(meta_class->name()) ? "_builtin" : "";
-  QString pro_file_name = meta_class->package().replace(".", "_") + builtIn + "/" + meta_class->package().replace(".", "_") + builtIn + ".pri";
+  QString fileBaseName = toFileNameBase(meta_class->package() + builtIn);
+  QString pro_file_name = fileBaseName + "/" + fileBaseName + ".pri";
   priGenerator->addHeader(pro_file_name, fileNameForClass(meta_class));
-  setupGenerator->addClass(meta_class->package().replace(".", "_") + builtIn, meta_class);
+  setupGenerator->addClass(meta_class->package() + builtIn, meta_class);
 
   QString include_block = "PYTHONQTWRAPPER_" + meta_class->name().toUpper() + "_H";
 
diff --git a/generator/shellimplgenerator.cpp b/generator/shellimplgenerator.cpp
@@ -73,7 +73,8 @@ void ShellImplGenerator::write(QTextStream &s, const AbstractMetaClass *meta_cla
   setCurrentScope(meta_class);
 
   QString builtIn = ShellGenerator::isBuiltIn(meta_class->name())?"_builtin":"";
-  QString pro_file_name = meta_class->package().replace(".", "_") + builtIn + "/" + meta_class->package().replace(".", "_") + builtIn + ".pri";
+  QString fileBaseName = toFileNameBase(meta_class->package() + builtIn);
+  QString pro_file_name = fileBaseName + "/" + fileBaseName + ".pri";
   priGenerator->addSource(pro_file_name, fileNameForClass(meta_class));
   
   s << "#include \"PythonQtWrapper_" << meta_class->name() << ".h\"" << endl << endl;
diff --git a/generator/typesystem_core.xml b/generator/typesystem_core.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0"?>
-<typesystem package="com.trolltech.qt.core">
+<typesystem package="com.trolltech.qt.Core">
   
   <rejection class="QSysInfo" enum-name="WinVersion"/>
   <rejection class="QSysInfo" enum-name="MacVersion"/>
diff --git a/generator/typesystem_gui.xml b/generator/typesystem_gui.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0"?>
-<typesystem package="com.trolltech.qt.gui">
+<typesystem package="com.trolltech.qt.Gui">
   <rejection class="QColormap"/>
   <rejection class="QIconEngineV2"/>
   <rejection class="QTextBlock::iterator"/>
diff --git a/generator/typesystem_multimedia.xml b/generator/typesystem_multimedia.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0"?>
-<typesystem package="com.trolltech.qt.multimedia">
+<typesystem package="com.trolltech.qt.Multimedia">
 
 <rejection class="QAbstractVideoBuffer" function-name="mapPlanes"/>
 <rejection class="QAbstractPlanarVideoBuffer"/>
diff --git a/generator/typesystem_network.xml b/generator/typesystem_network.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0"?>
-<typesystem package="com.trolltech.qt.network">
+<typesystem package="com.trolltech.qt.Network">
   <namespace-type name="QSsl">
     <include file-name="qssl.h" location="global"/>
   </namespace-type>
diff --git a/generator/typesystem_opengl.xml b/generator/typesystem_opengl.xml
@@ -1,7 +1,6 @@
 <?xml version="1.0"?>
-<typesystem package="com.trolltech.qt.opengl"><rejection class="QGL"/>
-
- 
+<typesystem package="com.trolltech.qt.OpenGL">
+  <rejection class="QGL"/>
 
   <rejection class="QGLColormap::QGLColormapData"/>
   <rejection class="QGLWidget" function-name="setMouseTracking"/>
diff --git a/generator/typesystem_qml.xml b/generator/typesystem_qml.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0"?>
-<typesystem package="com.trolltech.qt.qml">
+<typesystem package="com.trolltech.qt.Qml">
 
 <rejection class="QQmlEngine" function-name="singletonInstance&lt;QJSValue&gt;"/>
 
diff --git a/generator/typesystem_quick.xml b/generator/typesystem_quick.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0"?>
-<typesystem package="com.trolltech.qt.quick">
+<typesystem package="com.trolltech.qt.Quick">
 
 <!-- not yet supported: -->
 <rejection class="QSGMaterial"/>
diff --git a/generator/typesystem_sql.xml b/generator/typesystem_sql.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0"?>
-<typesystem package="com.trolltech.qt.sql">
+<typesystem package="com.trolltech.qt.Sql">
   <rejection class="QSqlDriverCreator"/>
   <rejection class="QSqlDriverPlugin"/>
   <rejection class="QSqlDriverFactoryInterface"/>
diff --git a/generator/typesystem_svg.xml b/generator/typesystem_svg.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0"?>
-<typesystem package="com.trolltech.qt.svg">
+<typesystem package="com.trolltech.qt.Svg">
   
   <namespace-type name="QSvg"/>
 
diff --git a/generator/typesystem_uitools.xml b/generator/typesystem_uitools.xml
@@ -1,4 +1,4 @@
-<typesystem package="com.trolltech.qt.uitools">
+<typesystem package="com.trolltech.qt.UiTools">
 
   <object-type name="QUiLoader"/>
   
diff --git a/generator/typesystem_webenginewidgets.xml b/generator/typesystem_webenginewidgets.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0"?>
-<typesystem package="com.trolltech.qt.webenginewidgets">
+<typesystem package="com.trolltech.qt.WebEngineWidgets">
 
     <object-type name="QWebEngineView">
     </object-type>
diff --git a/generator/typesystem_webkit.xml b/generator/typesystem_webkit.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0"?>
-<typesystem package="com.trolltech.qt.webkit">
+<typesystem package="com.trolltech.qt.WebKit">
 <rejection class="WebCore"/>
 <suppress-warning text="WARNING(MetaJavaBuilder) :: skipping field 'QWebPluginFactory_Plugin::mimeTypes' with unmatched type 'QList&lt;MimeType&gt;'"/>
     <namespace-type name="WebCore"/>
diff --git a/generator/typesystem_xml.xml b/generator/typesystem_xml.xml
@@ -1,5 +1,6 @@
 <?xml version="1.0"?>
-<typesystem package="com.trolltech.qt.xml"><rejection class="QXmlNamespaceSupport"/>
+<typesystem package="com.trolltech.qt.Xml">
+    <rejection class="QXmlNamespaceSupport"/>
     <rejection class="QXmlAttributes::Attribute"/>
     <rejection class="QDomNode" field-name="impl"/>
 
diff --git a/generator/typesystem_xmlpatterns.xml b/generator/typesystem_xmlpatterns.xml
@@ -1,6 +1,5 @@
 <?xml version="1.0"?>
-<typesystem package="com.trolltech.qt.xmlpatterns"><suppress-warning text="WARNING(MetaJavaBuilder) :: unhandled enum value: ForwardAxis in QXmlNodeModelIndex::Axis"/><suppress-warning text="WARNING(MetaJavaBuilder) :: unhandled enum value: ReverseAxis in QXmlNodeModelIndex::Axis"/>
-
+<typesystem package="com.trolltech.qt.XmlPatterns">
 
   <namespace-type name="QPatternist"/>
   <namespace-type name="QPatternistSDK"/>
@@ -112,6 +111,8 @@
   </object-type>
 
 
+  <suppress-warning text="WARNING(MetaJavaBuilder) :: unhandled enum value: ForwardAxis in QXmlNodeModelIndex::Axis"/>
+  <suppress-warning text="WARNING(MetaJavaBuilder) :: unhandled enum value: ReverseAxis in QXmlNodeModelIndex::Axis"/>
 
   <suppress-warning text="WARNING(MetaJavaBuilder) :: horribly broken type ''"/>
   <suppress-warning text="WARNING(MetaJavaBuilder) :: template baseclass 'QExplicitlySharedDataPointer&lt;QXmlSerializer&gt;' of 'QXmlSerializerPointer' is not known"/>

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-<typesystem package="com.trolltech.qt.uitools">`
	`1`	`+<typesystem package="com.trolltech.qt.UiTools">`
`2`	`2`
`3`	`3`	`<object-type name="QUiLoader"/>`
`4`	`4`