Clippify

Author: jedisct1

src/lib.rs

@@ -1,6 +1,7 @@
 #![cfg_attr(not(test), no_std)]
 #![allow(clippy::unreadable_literal)]
 #![allow(clippy::cast_lossless)]
+#![allow(clippy::many_single_char_names)]
 
 pub mod sip;
 pub mod sip128;

src/sip128.rs

@@ -33,9 +33,9 @@ impl From<u128> for Hash128 {
     }
 }
 
-impl Into<u128> for Hash128 {
-    fn into(self) -> u128 {
-        (self.h1 as u128) | ((self.h2 as u128) << 64)
+impl From<Hash128> for u128 {
+    fn from(h: Hash128) -> u128 {
+        (h.h1 as u128) | ((h.h2 as u128) << 64)
     }
 }
 

src/tests.rs

@@ -250,7 +250,7 @@ fn test_hash_usize() {
 #[test]
 #[cfg(target_arch = "x86_64")]
 fn test_hash_usize() {
-    let val = 0xdeadbeef_deadbeef_u64;
+    let val = 0xdead_beef_dead_beef_u64;
     assert_eq!(hash(&(val as u64)), hash(&(val as usize)));
     assert_ne!(hash(&(val as u32)), hash(&(val as usize)));
 }
@@ -264,15 +264,15 @@ fn test_hash_usize() {
 
 #[test]
 fn test_hash_idempotent() {
-    let val64 = 0xdeadbeef_deadbeef_u64;
+    let val64 = 0xdead_beef_dead_beef_u64;
     assert_eq!(hash(&val64), hash(&val64));
     let val32 = 0xdeadbeef_u32;
     assert_eq!(hash(&val32), hash(&val32));
 }
 
 #[test]
 fn test_hash_no_bytes_dropped_64() {
-    let val = 0xdeadbeef_deadbeef_u64;
+    let val = 0xdead_beef_dead_beef_u64;
 
     assert_ne!(hash(&val), hash(&zero_byte(val, 0)));
     assert_ne!(hash(&val), hash(&zero_byte(val, 1)));
@@ -323,7 +323,7 @@ fn test_hash_no_concat_alias() {
 
 #[test]
 fn test_hash_serde() {
-    let val64 = 0xdeadbeef_deadbeef_u64;
+    let val64 = 0xdead_beef_dead_beef_u64;
     let hash = hash(&val64);
     let serialized = serde_json::to_string(&hash).unwrap();
     let deserialized: u64 = serde_json::from_str(&serialized).unwrap();

src/tests128.rs

@@ -95,7 +95,7 @@ fn test_siphash128_2_4() {
 
 #[test]
 fn test_siphash128_serde() {
-    let val64 = 0xdeadbeef_deadbeef_u64;
+    let val64 = 0xdead_beef_dead_beef_u64;
     let hash = hash(&val64);
     let serialized = serde_json::to_string(&hash).unwrap();
     let deserialized: [u8; 16] = serde_json::from_str(&serialized).unwrap();