Skip to content

Commit 63f3ca7

Browse files
crisbetojelbourn
authored andcommitted
build: fix builds not failing with compilation errors in unit tests (angular#9248)
Fixes the CI continuing to run even though it failed to compile, due to a couple of promises that weren't rejecting properly. This should avoids things like angular#9073 slipping through.
1 parent 67ddb25 commit 63f3ca7

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

tools/package-tools/build-package.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,7 @@ export class BuildPackage {
117117
.catch(() => {
118118
const error = red(`Failed to compile ${secondaryEntryPoint} using ${entryPointTsconfigPath}`);
119119
console.error(error);
120+
return Promise.reject(error);
120121
});
121122
}
122123

tools/package-tools/compile-entry-point.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ export async function compileEntryPoint(buildPackage: BuildPackage, tsconfigName
3333
.catch(() => {
3434
const error = red(`Failed to compile ${secondaryEntryPoint} using ${entryPointTsconfigPath}`);
3535
console.error(error);
36+
return Promise.reject(error);
3637
});
3738
}
3839

0 commit comments

Comments
 (0)