Skip to content

Commit 8a99d61

Browse files
committed
canio: Message: remove size property
This is just duplicating what len(message.data) gives you.
1 parent 6f98f31 commit 8a99d61

File tree

1 file changed

+0
-31
lines changed

1 file changed

+0
-31
lines changed

shared-bindings/_canio/Message.c

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -146,36 +146,6 @@ STATIC const mp_obj_property_t canio_message_data_obj = {
146146
};
147147

148148

149-
//| size: int
150-
//| """The length of the message, or the length of the requested data in the case of an rtr
151-
//|
152-
//| Assigning to the length sets all the data bytes to zero"""
153-
//|
154-
STATIC mp_obj_t canio_message_size_get(const mp_obj_t self_in) {
155-
canio_message_obj_t *self = self_in;
156-
return MP_OBJ_NEW_SMALL_INT(common_hal_canio_message_get_size(self));
157-
}
158-
MP_DEFINE_CONST_FUN_OBJ_1(canio_message_size_get_obj, canio_message_size_get);
159-
160-
STATIC mp_obj_t canio_message_size_set(const mp_obj_t self_in, const mp_obj_t size_in) {
161-
canio_message_obj_t *self = self_in;
162-
int size = mp_obj_get_int(size_in);
163-
if (size > 8) {
164-
mp_raise_ValueError(translate("Messages limited to 8 bytes"));
165-
}
166-
common_hal_canio_message_set_size(self, size);
167-
return mp_const_none;
168-
}
169-
MP_DEFINE_CONST_FUN_OBJ_2(canio_message_size_set_obj, canio_message_size_set);
170-
171-
172-
STATIC const mp_obj_property_t canio_message_size_obj = {
173-
.base.type = &mp_type_property,
174-
.proxy = {(mp_obj_t)&canio_message_size_get_obj,
175-
(mp_obj_t)&canio_message_size_set_obj,
176-
(mp_obj_t)&mp_const_none_obj},
177-
};
178-
179149
//| extended: bool
180150
//| """True if the message represents a remote transmission request (RTR)"""
181151
//|
@@ -229,7 +199,6 @@ STATIC const mp_obj_property_t canio_message_rtr_obj = {
229199
STATIC const mp_rom_map_elem_t canio_message_locals_dict_table[] = {
230200
{ MP_ROM_QSTR(MP_QSTR_id), MP_ROM_PTR(&canio_message_id_obj) },
231201
{ MP_ROM_QSTR(MP_QSTR_data), MP_ROM_PTR(&canio_message_data_obj) },
232-
{ MP_ROM_QSTR(MP_QSTR_size), MP_ROM_PTR(&canio_message_size_obj) },
233202
{ MP_ROM_QSTR(MP_QSTR_rtr), MP_ROM_PTR(&canio_message_rtr_obj) },
234203
{ MP_ROM_QSTR(MP_QSTR_extended), MP_ROM_PTR(&canio_message_extended_obj) },
235204
};

0 commit comments

Comments
 (0)