Skip to content

Commit a52395a

Browse files
authored
Merge pull request adafruit#4095 from hierophect/socket-timeout
Fix default socket timeout
2 parents 9bceb32 + ddd516a commit a52395a

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

ports/esp32s2/common-hal/socketpool/Socket.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ socketpool_socket_obj_t* common_hal_socketpool_socket_accept(socketpool_socket_o
135135
while (newsoc == -1 &&
136136
!timed_out &&
137137
!mp_hal_is_interrupted()) {
138-
if (self->timeout_ms != (uint)-1) {
138+
if (self->timeout_ms != (uint)-1 && self->timeout_ms != 0) {
139139
timed_out = supervisor_ticks_ms64() - start_ticks >= self->timeout_ms;
140140
}
141141
RUN_BACKGROUND_TASKS;
@@ -251,7 +251,7 @@ mp_uint_t common_hal_socketpool_socket_recv_into(socketpool_socket_obj_t* self,
251251
while (received == -1 &&
252252
!timed_out &&
253253
!mp_hal_is_interrupted()) {
254-
if (self->timeout_ms != (uint)-1) {
254+
if (self->timeout_ms != (uint)-1 && self->timeout_ms != 0) {
255255
timed_out = supervisor_ticks_ms64() - start_ticks >= self->timeout_ms;
256256
}
257257
RUN_BACKGROUND_TASKS;
@@ -362,7 +362,7 @@ mp_uint_t common_hal_socketpool_socket_recvfrom_into(socketpool_socket_obj_t* se
362362
while (received == -1 &&
363363
!timed_out &&
364364
!mp_hal_is_interrupted()) {
365-
if (self->timeout_ms != (uint)-1) {
365+
if (self->timeout_ms != (uint)-1 && self->timeout_ms != 0) {
366366
timed_out = supervisor_ticks_ms64() - start_ticks >= self->timeout_ms;
367367
}
368368
RUN_BACKGROUND_TASKS;

ports/esp32s2/common-hal/socketpool/SocketPool.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ socketpool_socket_obj_t* common_hal_socketpool_socket(socketpool_socketpool_obj_
7777
sock->type = socket_type;
7878
sock->family = addr_family;
7979
sock->ipproto = ipproto;
80+
sock->timeout_ms = (uint)-1;
8081

8182
sock->tls = NULL;
8283
sock->ssl_context = NULL;

0 commit comments

Comments
 (0)