Skip to content

Commit be4cfdd

Browse files
committed
Use TOTAL_GPIO_COUNT instead of magic number 30
1 parent 0fa5aa3 commit be4cfdd

File tree

1 file changed

+5
-4
lines changed
  • ports/raspberrypi/common-hal/microcontroller

1 file changed

+5
-4
lines changed

ports/raspberrypi/common-hal/microcontroller/Pin.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626

2727
#include "py/runtime.h"
2828

29+
#include "common-hal/microcontroller/__init__.h"
2930
#include "shared-bindings/microcontroller/Pin.h"
3031

3132
#include "supervisor/shared/rgb_led_status.h"
@@ -46,7 +47,7 @@ bool speaker_enable_in_use;
4647
STATIC uint32_t never_reset_pins;
4748

4849
void reset_all_pins(void) {
49-
for (size_t i = 0; i < 30; i++) {
50+
for (size_t i = 0; i < TOTAL_GPIO_COUNT; i++) {
5051
if ((never_reset_pins & (1 << i)) != 0) {
5152
continue;
5253
}
@@ -55,15 +56,15 @@ void reset_all_pins(void) {
5556
}
5657

5758
void never_reset_pin_number(uint8_t pin_number) {
58-
if (pin_number >= 32) {
59+
if (pin_number >= TOTAL_GPIO_COUNT) {
5960
return;
6061
}
6162

6263
never_reset_pins |= 1 << pin_number;
6364
}
6465

6566
void reset_pin_number(uint8_t pin_number) {
66-
if (pin_number >= 32) {
67+
if (pin_number >= TOTAL_GPIO_COUNT) {
6768
return;
6869
}
6970

@@ -134,7 +135,7 @@ void claim_pin(const mcu_pin_obj_t* pin) {
134135
}
135136

136137
bool pin_number_is_free(uint8_t pin_number) {
137-
if (pin_number >= 30) {
138+
if (pin_number >= TOTAL_GPIO_COUNT) {
138139
return false;
139140
}
140141

0 commit comments

Comments
 (0)