[print-dev-env] Skip cache if lockfile has changed

Author: savil

internal/impl/devbox.go

@@ -951,17 +951,20 @@ func (d *Devbox) ensurePackagesAreInstalledAndComputeEnv(
 ) (map[string]string, error) {
 	defer debug.FunctionTimer().End()
 
+	// We need to check the lockfile status prior to ensurePackagesAreInstalled
+	// since it will update the lockfile to be up-to-date.
+	upToDate, err := d.lockfile.IsUpToDateAndInstalled()
+	if err != nil {
+		return nil, err
+	}
+
 	// When ensurePackagesAreInstalled is called with ensure=true, it always
 	// returns early if the lockfile is up to date. So we don't need to check here
 	if err := d.ensurePackagesAreInstalled(ctx, ensure); err != nil {
 		return nil, err
 	}
 
-	// Since ensurePackagesAreInstalled calls computeNixEnv when not up do date,
-	// it's ok to use usePrintDevEnvCache=true here always. This does end up
-	// doing some non-nix work twice if lockfile is not up to date.
-	// TODO: Improve this to avoid extra work.
-	return d.computeNixEnv(ctx, true)
+	return d.computeNixEnv(ctx, upToDate /*usePrintDevEnvCache*/)
 }
 
 func (d *Devbox) nixPrintDevEnvCachePath() string {