rename file for pathlists

Author: savil

internal/impl/devbox.go

@@ -325,7 +325,6 @@ func (d *Devbox) EnvVars(ctx context.Context) ([]string, error) {
 }
 
 func (d *Devbox) ShellEnvHash(ctx context.Context) (string, error) {
-	// TODO savil: correct?
 	envs, err := d.nixEnv(ctx)
 	if err != nil {
 		return "", err

internal/impl/envpath/envpath.go renamed to internal/impl/envpath/pathlists.go

@@ -0,0 +1,32 @@
+package envpath
+
+import (
+	"testing"
+)
+
+func TestCleanEnvPath(t *testing.T) {
+	tests := []struct {
+		name    string
+		inPath  string
+		outPath string
+	}{
+		{
+			name:    "NoEmptyPaths",
+			inPath:  "/usr/local/bin::",
+			outPath: "/usr/local/bin",
+		},
+		{
+			name:    "NoRelativePaths",
+			inPath:  "/usr/local/bin:/usr/bin:../test:/bin:/usr/sbin:/sbin:.:..",
+			outPath: "/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin",
+		},
+	}
+	for _, test := range tests {
+		t.Run(test.name, func(t *testing.T) {
+			got := JoinPathLists(test.inPath)
+			if got != test.outPath {
+				t.Errorf("Got incorrect cleaned PATH.\ngot:  %s\nwant: %s", got, test.outPath)
+			}
+		})
+	}
+}

internal/impl/envpath/pathlists_test.go

@@ -13,7 +13,6 @@ import (
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
-	"go.jetpack.io/devbox/internal/impl/envpath"
 	"go.jetpack.io/devbox/internal/shellgen"
 )
 
@@ -106,30 +105,3 @@ If the new shellrc is correct, you can update the golden file with:
 		})
 	}
 }
-
-func TestCleanEnvPath(t *testing.T) {
-	tests := []struct {
-		name    string
-		inPath  string
-		outPath string
-	}{
-		{
-			name:    "NoEmptyPaths",
-			inPath:  "/usr/local/bin::",
-			outPath: "/usr/local/bin",
-		},
-		{
-			name:    "NoRelativePaths",
-			inPath:  "/usr/local/bin:/usr/bin:../test:/bin:/usr/sbin:/sbin:.:..",
-			outPath: "/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin",
-		},
-	}
-	for _, test := range tests {
-		t.Run(test.name, func(t *testing.T) {
-			got := envpath.JoinPathLists(test.inPath)
-			if got != test.outPath {
-				t.Errorf("Got incorrect cleaned PATH.\ngot:  %s\nwant: %s", got, test.outPath)
-			}
-		})
-	}
-}