rename to preservePathStack

Author: savil

internal/boxcli/install.go

@@ -39,7 +39,7 @@ func installCmdFunc(cmd *cobra.Command, flags runCmdFlags) error {
 	if err != nil {
 		return errors.WithStack(err)
 	}
-	if err = box.Install(cmd.Context(), false /*pathStackInPlace*/); err != nil {
+	if err = box.Install(cmd.Context(), false /*preservePathStack*/); err != nil {
 		return errors.WithStack(err)
 	}
 	fmt.Fprintln(cmd.ErrOrStderr(), "Finished installing packages.")

internal/boxcli/shell.go

@@ -66,7 +66,7 @@ func runShellCmd(cmd *cobra.Command, flags shellCmdFlags) error {
 	if flags.printEnv {
 		// false for includeHooks is because init hooks is not compatible with .envrc files generated
 		// by versions older than 0.4.6
-		script, err := box.NixEnv(cmd.Context(), false /*includeHooks*/, false /*pathStackInPlace*/)
+		script, err := box.NixEnv(cmd.Context(), false /*includeHooks*/, false /*preservePathStack*/)
 		if err != nil {
 			return err
 		}

internal/boxcli/shellenv.go

@@ -15,11 +15,11 @@ import (
 
 type shellEnvCmdFlags struct {
 	envFlag
-	config           configFlags
-	runInitHook      bool
-	install          bool
-	pure             bool
-	pathStackInPlace bool
+	config            configFlags
+	runInitHook       bool
+	install           bool
+	pure              bool
+	preservePathStack bool
 }
 
 func shellEnvCmd() *cobra.Command {
@@ -50,10 +50,10 @@ func shellEnvCmd() *cobra.Command {
 	command.Flags().BoolVar(
 		&flags.pure, "pure", false, "If this flag is specified, devbox creates an isolated environment inheriting almost no variables from the current environment. A few variables, in particular HOME, USER and DISPLAY, are retained.")
 	command.Flags().BoolVar(
-		&flags.pure, "path-stack-in-place", true,
+		&flags.preservePathStack, "preserve-path-stack", false,
 		"If true, Devbox will not give top priority to the PATH of this project's shellenv. "+
 			"This project's place in the path stack will be unchanged.")
-	_ = command.Flags().MarkHidden("path-stack-in-place")
+	_ = command.Flags().MarkHidden("preserve-path-stack")
 
 	flags.config.register(command)
 	flags.envFlag.register(command)
@@ -79,12 +79,12 @@ func shellEnvFunc(cmd *cobra.Command, flags shellEnvCmdFlags) (string, error) {
 	}
 
 	if flags.install {
-		if err := box.Install(cmd.Context(), flags.pathStackInPlace); err != nil {
+		if err := box.Install(cmd.Context(), flags.preservePathStack); err != nil {
 			return "", err
 		}
 	}
 
-	envStr, err := box.NixEnv(cmd.Context(), flags.runInitHook, flags.pathStackInPlace)
+	envStr, err := box.NixEnv(cmd.Context(), flags.runInitHook, flags.preservePathStack)
 	if err != nil {
 		return "", err
 	}