lucille: rewrite for clarity

Author: savil

internal/impl/update.go

@@ -9,6 +9,7 @@ import (
 
 	"go.jetpack.io/devbox/internal/boxcli/featureflag"
 	"go.jetpack.io/devbox/internal/devpkg"
+	"go.jetpack.io/devbox/internal/lock"
 	"go.jetpack.io/devbox/internal/nix"
 	"go.jetpack.io/devbox/internal/nix/nixprofile"
 	"go.jetpack.io/devbox/internal/searcher"
@@ -113,23 +114,26 @@ func (d *Devbox) updateDevboxPackage(
 	if err != nil {
 		return err
 	}
-	var needsSysInfo bool
-	var needsLocalStorePath bool
+
+	var sysInfo *lock.SystemInfo
+	var caStorePath string
 	if featureflag.RemoveNixpkgs.Enabled() {
-		userSysInfo := d.lockfile.Packages[pkg.Raw].Systems[userSystem]
-		needsSysInfo = userSysInfo == nil
-		if !needsSysInfo {
+		sysInfo = d.lockfile.Packages[pkg.Raw].Systems[userSystem]
+		if sysInfo == nil {
 			// Check if the LocalStorePath is missing for the user's system.
-			// Since any one user cannot add this field for all systems, 
+			// Since any one user cannot add this field for all systems,
 			// we'll need to progressively add it to a project's lockfile.
-			needsLocalStorePath = userSysInfo.LocalStorePath == ""
+			caStorePath = sysInfo.LocalStorePath
 		}
 	}
-	if needsSysInfo {
+
+	if sysInfo != nil {
 		d.lockfile.Packages[pkg.Raw] = newEntry
 		ux.Finfo(d.writer, "Updated system information for %s\n", pkg)
 		return nil
-	} else if needsLocalStorePath {
+	}
+
+	if caStorePath == "" {
 		// Update the LocalStorePath for the user's system
 		d.lockfile.Packages[pkg.Raw].Systems[userSystem].LocalStorePath = newEntry.Systems[userSystem].LocalStorePath
 		ux.Finfo(d.writer, "Updated system information for %s\n", pkg)