Skip to content

Commit 730d2df

Browse files
committed
Address linter and unsued command in package.json
1 parent a837552 commit 730d2df

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

internal/boxcli/integrate.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ func integrateVSCodeCmd() *cobra.Command {
4141
Hidden: true,
4242
Short: "Integrate devbox environment with VSCode.",
4343
RunE: func(cmd *cobra.Command, args []string) error {
44-
return runIntegrateVSCodeCmd(cmd, &flags)
44+
return runIntegrateVSCodeCmd(cmd)
4545
},
4646
}
4747
flags.config.register(command)
@@ -53,7 +53,7 @@ type parentMessage struct {
5353
ConfigDir string `json:"configDir"`
5454
}
5555

56-
func runIntegrateVSCodeCmd(cmd *cobra.Command, flags *integrateCmdFlags) error {
56+
func runIntegrateVSCodeCmd(cmd *cobra.Command) error {
5757

5858
// Setup process communication with node as parent
5959
channel, err := go2node.RunAsNodeChild()
@@ -68,7 +68,9 @@ func runIntegrateVSCodeCmd(cmd *cobra.Command, flags *integrateCmdFlags) error {
6868
}
6969
// Parse node process' message
7070
var message parentMessage
71-
json.Unmarshal(msg.Message, &message)
71+
if err = json.Unmarshal(msg.Message, &message); err != nil {
72+
return err
73+
}
7274

7375
// todo: add error handling - consider sending error message to parent process
7476
box, err := devbox.Open(&devopt.Opts{

vscode-extension/package.json

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,6 @@
3030
"command": "devbox.setupDevContainer",
3131
"title": "Devbox: Generate Dev Containers config files"
3232
},
33-
{
34-
"command": "devbox.shellenv",
35-
"title": "Devbox: Compute Devbox shell environment"
36-
},
3733
{
3834
"command": "devbox.reopen",
3935
"title": "Devbox: Reopen in Devbox shell environment"
@@ -69,10 +65,6 @@
6965
"command": "devbox.setupDevContainer",
7066
"when": "devbox.configFileExists == true"
7167
},
72-
{
73-
"command": "devbox.shellenv",
74-
"when": "devbox.configFileExists == true"
75-
},
7668
{
7769
"command": "devbox.reopen"
7870
},

0 commit comments

Comments
 (0)