devbox.findPackagesByName should be constructed from Config packages

Author: savil

internal/impl/devbox.go

@@ -962,22 +962,22 @@ func (d *Devbox) HasDeprecatedPackages() bool {
 	return false
 }
 
-func (d *Devbox) findPackageByName(name string) (string, error) {
-	results := map[string]bool{}
+func (d *Devbox) findPackageByName(name string) (*devpkg.Package, error) {
+	results := map[*devpkg.Package]bool{}
 	for _, pkg := range d.configPackages() {
 		if pkg.String() == name || pkg.CanonicalName() == name {
-			results[pkg.String()] = true
+			results[pkg] = true
 		}
 	}
 	if len(results) > 1 {
-		return "", usererr.New(
+		return nil, usererr.New(
 			"found multiple packages with name %s: %s. Please specify version",
 			name,
 			lo.Keys(results),
 		)
 	}
 	if len(results) == 0 {
-		return "", usererr.New("no package found with name %s", name)
+		return nil, usererr.New("no package found with name %s", name)
 	}
 	return lo.Keys(results)[0], nil
 }

internal/impl/packages.go

@@ -57,7 +57,9 @@ func (d *Devbox) Add(ctx context.Context, pkgsNames ...string) error {
 		// it. Ignore error (which is either missing or more than one). We search by
 		// CanonicalName so any legacy or versioned packages will be removed if they
 		// match.
-		if name, _ := d.findPackageByName(pkg.CanonicalName()); name != "" {
+		found, _ := d.findPackageByName(pkg.CanonicalName())
+		// TODO savil: should name be found.Raw?
+		if name := found.String(); name != "" {
 			if err := d.Remove(ctx, name); err != nil {
 				return err
 			}
@@ -134,9 +136,10 @@ func (d *Devbox) Remove(ctx context.Context, pkgs ...string) error {
 	missingPkgs := []string{}
 	for _, pkg := range lo.Uniq(pkgs) {
 		found, _ := d.findPackageByName(pkg)
-		if found != "" {
-			packagesToUninstall = append(packagesToUninstall, found)
-			d.cfg.Packages.Remove(found)
+		if found != nil {
+			name := found.String() // TODO savil. should this be found.Raw?
+			packagesToUninstall = append(packagesToUninstall, name)
+			d.cfg.Packages.Remove(name)
 		} else {
 			missingPkgs = append(missingPkgs, pkg)
 		}

internal/impl/update.go

@@ -66,19 +66,19 @@ func (d *Devbox) Update(ctx context.Context, pkgs ...string) error {
 }
 
 func (d *Devbox) inputsToUpdate(pkgs ...string) ([]*devpkg.Package, error) {
-	var pkgsToUpdate []string
+	if len(pkgs) == 0 {
+		return d.configPackages(), nil
+	}
+
+	var pkgsToUpdate []*devpkg.Package
 	for _, pkg := range pkgs {
 		found, err := d.findPackageByName(pkg)
 		if err != nil {
 			return nil, err
 		}
 		pkgsToUpdate = append(pkgsToUpdate, found)
 	}
-	if len(pkgsToUpdate) == 0 {
-		pkgsToUpdate = d.PackageNames()
-	}
-
-	return devpkg.PackageFromStrings(pkgsToUpdate, d.lockfile), nil
+	return pkgsToUpdate, nil
 }
 
 func (d *Devbox) updateDevboxPackage(