Skip to content

Commit a58d8e9

Browse files
committed
[Remove Nixpkgs] Ensure we run cli-tests for oldest supported nix version, and 2.17
1 parent 1c4b8a9 commit a58d8e9

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

.github/workflows/cli-tests.yaml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,11 @@ jobs:
8282
# the devbox.json tests. We can require the other tests to complete before
8383
# merging, while keeping the others as an additional non-required signal
8484
run-devbox-json-tests: [true, false]
85+
# Run tests on:
86+
# 1. the oldest supported nix version (which is 2.9.0? But determinate-systems installer has 2.12.0)
87+
# 2. nix version 2.17.0 which introduces a new code path that minimizes nixpkgs downloads.
88+
# 3. latest nix version (currently, that is 2.17.0, so omitted)
89+
nix-version: ["2.12.0", "2.17.0"]
8590
exclude:
8691
- is-main: false
8792
os: "${{ inputs.run-mac-tests && 'dummy' || 'macos-latest' }}"
@@ -112,6 +117,7 @@ jobs:
112117
with:
113118
logger: pretty
114119
extra-conf: experimental-features = ca-derivations fetch-closure
120+
nix-package-url: https://releases.nixos.org/nix/nix-${{ matrix.nix-version }}/nix-${{ matrix.nix-version }}-${{ runner.arch == 'X64' && 'x86_64' || 'aarch64' }}-${{ runner.os == 'macOS' && 'darwin' || 'linux' }}.tar.xz
115121
- name: Run tests
116122
env:
117123
# For devbox.json tests, we default to non-debug mode since the debug output is less useful than for unit testscripts.
@@ -163,7 +169,7 @@ jobs:
163169
strategy:
164170
matrix:
165171
os: [ubuntu-latest, macos-latest]
166-
version: [2.15.1, 2.16.1, 2.17.0]
172+
nix-version: [2.15.1, 2.16.1, 2.17.0]
167173
runs-on: ${{ matrix.os }}
168174
steps:
169175
- uses: actions/checkout@v3
@@ -177,7 +183,7 @@ jobs:
177183
with:
178184
logger: pretty
179185
extra-conf: experimental-features = ca-derivations fetch-closure
180-
nix-package-url: https://releases.nixos.org/nix/nix-${{ matrix.version }}/nix-${{ matrix.version }}-${{ runner.arch == 'X64' && 'x86_64' || 'aarch64' }}-${{ runner.os == 'macOS' && 'darwin' || 'linux' }}.tar.xz
186+
nix-package-url: https://releases.nixos.org/nix/nix-${{ matrix.nix-version }}/nix-${{ matrix.nix-version }}-${{ runner.arch == 'X64' && 'x86_64' || 'aarch64' }}-${{ runner.os == 'macOS' && 'darwin' || 'linux' }}.tar.xz
181187
- name: Run devbox install, devbox run, devbox rm
182188
run: |
183189
echo "::group::Nix version"

0 commit comments

Comments
 (0)