Skip to content

Commit afe7790

Browse files
committed
[perf UX] add spinner to print-dev-env output
1 parent ca4d880 commit afe7790

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

internal/impl/devbox.go

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@ import (
1818
"strconv"
1919
"strings"
2020
"text/tabwriter"
21+
"time"
2122

23+
"github.com/briandowns/spinner"
2224
"github.com/pkg/errors"
2325
"github.com/samber/lo"
2426
"go.jetpack.io/devbox/internal/devpkg"
@@ -781,11 +783,22 @@ func (d *Devbox) computeNixEnv(ctx context.Context, usePrintDevEnvCache bool) (m
781783
originalEnv := make(map[string]string, len(env))
782784
maps.Copy(originalEnv, env)
783785

786+
var spinny *spinner.Spinner
787+
if !usePrintDevEnvCache {
788+
spinny = spinner.New(spinner.CharSets[11], 100*time.Millisecond, spinner.WithWriter(d.stderr))
789+
spinny.FinalMSG = "✓ Got env-vars from nix.\n"
790+
spinny.Suffix = " Getting env-vars from nix...\n"
791+
spinny.Start()
792+
}
793+
784794
vaf, err := d.nix.PrintDevEnv(ctx, &nix.PrintDevEnvArgs{
785795
FlakeDir: d.flakeDir(),
786796
PrintDevEnvCachePath: d.nixPrintDevEnvCachePath(),
787797
UsePrintDevEnvCache: usePrintDevEnvCache,
788798
})
799+
if spinny != nil {
800+
spinny.Stop()
801+
}
789802
if err != nil {
790803
return nil, err
791804
}

0 commit comments

Comments
 (0)