Combine checks and parsing of versioned packages

Author: hezhizhen

internal/fileutil/fileutil.go

@@ -55,3 +55,10 @@ func FileContains(path string, substring string) (bool, error) {
 	}
 	return strings.Contains(string(data), substring), nil
 }
+
+// ParseVersionedPackage checks if the given package is a versioned package (`[email protected]`)
+// and returns its name and version
+func ParseVersionedPackage(pkg string) (string, string, bool) {
+	name, version, found := strings.Cut(pkg, "@")
+	return name, version, found && name != "" && version != ""
+}

internal/impl/update.go

@@ -7,7 +7,7 @@ import (
 	"context"
 	"fmt"
 
-	"go.jetpack.io/devbox/internal/lock"
+	"go.jetpack.io/devbox/internal/fileutil"
 	"go.jetpack.io/devbox/internal/searcher"
 	"go.jetpack.io/devbox/internal/ux"
 	"go.jetpack.io/devbox/internal/wrapnix"
@@ -27,7 +27,7 @@ func (d *Devbox) Update(ctx context.Context, pkgs ...string) error {
 	}
 
 	for _, pkg := range pkgsToUpdate {
-		if !lock.IsVersionedPackage(pkg) {
+		if _, _, versioned := fileutil.ParseVersionedPackage(pkg); !versioned {
 			fmt.Fprintf(d.writer, "Skipping %s because it is not a versioned package\n", pkg)
 			continue
 		}

internal/lock/lockfile.go

@@ -12,6 +12,7 @@ import (
 
 	"go.jetpack.io/devbox/internal/boxcli/featureflag"
 	"go.jetpack.io/devbox/internal/cuecfg"
+	"go.jetpack.io/devbox/internal/fileutil"
 )
 
 const lockFileVersion = "1"
@@ -72,7 +73,7 @@ func (l *File) Resolve(pkg string) (*Package, error) {
 	if entry, ok := l.Packages[pkg]; !ok || entry.Resolved == "" {
 		locked := &Package{}
 		var err error
-		if IsVersionedPackage(pkg) {
+		if _, _, versioned := fileutil.ParseVersionedPackage(pkg); versioned {
 			locked, err = l.resolver.Resolve(pkg)
 			if err != nil {
 				return nil, err
@@ -110,15 +111,11 @@ func (l *File) LegacyNixpkgsPath(pkg string) string {
 	)
 }
 
-func IsVersionedPackage(pkg string) bool {
-	name, version, found := strings.Cut(pkg, "@")
-	return found && name != "" && version != ""
-}
-
 // This probably belongs in input.go but can't add it there because it will
 // create a circular dependency. We could move Input into own package.
 func IsLegacyPackage(pkg string) bool {
-	return !IsVersionedPackage(pkg) &&
+	_, _, versioned := fileutil.ParseVersionedPackage(pkg)
+	return !versioned &&
 		!strings.Contains(pkg, ":") &&
 		// We don't support absolute paths without "path:" prefix, but adding here
 		// just inc ase we ever do.

internal/searcher/client.go

@@ -9,10 +9,10 @@ import (
 	"io"
 	"net/http"
 	"net/url"
-	"strings"
 
 	"go.jetpack.io/devbox/internal/boxcli/usererr"
 	"go.jetpack.io/devbox/internal/envir"
+	"go.jetpack.io/devbox/internal/fileutil"
 	"go.jetpack.io/devbox/internal/lock"
 	"go.jetpack.io/devbox/internal/nix"
 )
@@ -52,7 +52,7 @@ func (c *client) SearchVersion(query, version string) (*SearchResult, error) {
 }
 
 func (c *client) Resolve(pkg string) (*lock.Package, error) {
-	name, version, _ := strings.Cut(pkg, "@")
+	name, version, _ := fileutil.ParseVersionedPackage(pkg)
 	if version == "" {
 		return nil, usererr.New("No version specified for %q.", name)
 	}