[wrappers] Improve wrappers in multi-project env #1067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savil
approved these changes
Jun 1, 2023
| @@ -95,10 +96,10 @@ func CreateWrappers(ctx context.Context, devbox devboxer) error { | |||
| } | |||
|
|
|||
| type createWrapperArgs struct { | |||
| devboxer | |||
There was a problem hiding this comment.
as in, I see you removed ProjectDir field and added devboxer field
I also see that you set these fields above.
But I don't see any callsites being updated that used to use createWrapperArgs.ProjectDir but now use createWrapperArgs.ProjectDir()
There was a problem hiding this comment.
ahh, its cause it is passed into go-templates and in go-templates the .ProjectDir can be used for fields and methods?
I hate go-templates.
There was a problem hiding this comment.
I initially wanted to use it for ShellEnvHash function as well but that requires a context :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a possible cause of #881 (comment)
bin wrappers belong to a specific project so we should not have a single global hash.
How was it tested?
devbox shellcalled binaries, inspected wrappers
devbox add curlcalled binaries, inspected wrappers