fix: don't error when existing symlink points at correct path #1081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #1073 |
|
confirmed this resolves the issue on macos and linux. |
savil
approved these changes
Jun 1, 2023
| @@ -144,6 +144,18 @@ func createSymlinksForSupportDirs(projectDir string) error { | |||
| newname := filepath.Join(projectDir, plugin.WrapperPath, dir.Name()) | |||
|
|
|||
| if err := os.Symlink(oldname, newname); err != nil { | |||
| // ignore if the symlink already exists | |||
| if errors.Is(err, os.ErrExist) { | |||
There was a problem hiding this comment.
Ideally, fs.ErrExist since os.ErrExist is kinda deprecated, but nbd
mikeland73
pushed a commit
that referenced
this pull request
Jun 1, 2023
## Summary Update error handling in wrapnix package to succeed if intended symlinks already exist ## How was it tested? Manually testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update error handling in wrapnix package to succeed if intended symlinks already exist
How was it tested?
Manually testing.