Skip to content

[wrappers] shellenv should not create bin wrappers #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

mikeland73
Copy link
Contributor

Summary

Fixes #1073

The underlying cause of #1073 is that we were creating bin wrappers in shellenv which can get called a lot (and in parallel) this was leading to race conditions.

We should still try to limit shellenv calls (because they slow things down), but this fixes the race condition.

cc: @bketelsen

How was it tested?

Since I could not repro race condition, I created a setup that simulated it:

  • Wrote some testing code that would save a file to /tmp every time create wrappers is called.
  • Setup the environment to call a bin wrapper for every command
  • Before change, saw new /tmp file being created on every command.
  • After change, no new /tmp file was getting created.
  • Tested devbox install for sanity.

@mikeland73 mikeland73 merged commit 2f1d769 into main Jun 1, 2023
@mikeland73 mikeland73 deleted the landau/dont-create-wrappers-on-shellenv branch June 1, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Symlink error message when starting a new terminal window
2 participants