[wrappers] shellenv should not create bin wrappers #1082
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1073
The underlying cause of #1073 is that we were creating bin wrappers in shellenv which can get called a lot (and in parallel) this was leading to race conditions.
We should still try to limit shellenv calls (because they slow things down), but this fixes the race condition.
cc: @bketelsen
How was it tested?
Since I could not repro race condition, I created a setup that simulated it:
devbox install
for sanity.