[shellenv] Fix infinite loop #1083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeland73
force-pushed
the
landau/fix-shellenv-loop
branch
from
1c22193 to
5292e1a
Compare
savil
approved these changes
Jun 1, 2023
internal/wrapnix/wrapper.sh.tmpl
Outdated
| We use ShellEnvHashKey to avoid re-sourcing shellenv. Since wrappers | ||
| call other wrappers and potentially modify the environment, we don't want the | ||
| environment to get re-written. | ||
| We use ShellEnvHashKey to prevent doing shellenv if the correct envrioment is |
|
|
||
| We use the guard to prevent infinite loop if something in shellenv causes | ||
| another wrapped binary to be called. The guard is specific to this project so shellenv | ||
| could still cause another project's shellenv to be called. |
There was a problem hiding this comment.
which is okay, and desirable, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1049
In certain cases, shellenv might call a wrapped binary causing an infinite loop. This prevents it.
How was it tested?
Called a test script and confirmed env var was set.