Skip to content

[push] Simplify git clone for push #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Conversation

hezhizhen
Copy link
Contributor

Summary

  1. clone .git only for push (See https://stackoverflow.com/questions/38999901/clone-only-the-git-directory-of-a-git-repo for more information)
  2. add CreateDevboxTempDIr to fileutil and reuse it in more cases

How was it tested?

@hezhizhen
Copy link
Contributor Author

@mikeland86 PTAL

@hezhizhen hezhizhen marked this pull request as ready for review June 3, 2023 09:30
@savil savil requested a review from mikeland73 June 5, 2023 18:58
Copy link
Contributor

@mikeland73 mikeland73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Awesome improvement.

@mikeland73
Copy link
Contributor

Small request, in the future please include a test plan (can be unit test or even just some bash commands). This provides move confidence that code was tested and gives reviewers a way to test it as well.

@mikeland73 mikeland73 merged commit 9098282 into jetify-com:main Jun 6, 2023
@hezhizhen
Copy link
Contributor Author

Small request, in the future please include a test plan (can be unit test or even just some bash commands). This provides move confidence that code was tested and gives reviewers a way to test it as well.

My mistake. I tried it locally, but I didn't provide test steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants