Skip to content

[RunScript] Add ctx parameter #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2023
Merged

[RunScript] Add ctx parameter #1118

merged 1 commit into from
Jun 7, 2023

Conversation

hezhizhen
Copy link
Contributor

Summary

Now that the implementation of RunScript is using context.Background(), I think it's better to pass the context.Context from cmd.Context().

How was it tested?

None

@hezhizhen hezhizhen marked this pull request as ready for review June 7, 2023 10:28
@mikeland73 mikeland73 merged commit ae6932f into jetify-com:main Jun 7, 2023
@hezhizhen hezhizhen deleted the runscript branch August 9, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeland73 mikeland73 mikeland73 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hezhizhen @mikeland73