Skip to content

[dockerfile] Copying local flakes in dockerfile #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

mohsenari
Copy link
Collaborator

Summary

This PR addresses the issue in generated dockerfiles by devbox generate dockerfile and devbox generate devcontainer in which packages mentioned as local flakes are not copied over in dockerfile and user has to manually do that.
Addresses: #1051

How was it tested?

@mohsenari mohsenari requested review from Lagoja and ipince June 14, 2023 02:44
@Lagoja
Copy link
Contributor

Lagoja commented Jun 15, 2023

This Dockerfile doesn't copy any of my code, is that expected?

@mohsenari
Copy link
Collaborator Author

mohsenari commented Jun 15, 2023

This Dockerfile doesn't copy any of my code, is that expected?

@Lagoja are you adding local flake to devbox.json? for every package that has this format in devbox.json: path:./path/to/flake#name it should add a line in Dockerfile like this: COPY ./path/to/flake ./path/to/flake

@mohsenari mohsenari merged commit a19be01 into main Jun 15, 2023
@mohsenari mohsenari deleted the mohsen--dockerfile-local-flakes branch June 15, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants