Skip to content

[searcher] Add SearchOption and handle host error #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2023
Merged

[searcher] Add SearchOption and handle host error #1173

merged 1 commit into from
Jun 27, 2023

Conversation

hezhizhen
Copy link
Contributor

Summary

  1. Add SearchOption for better declaration
  2. Handle the error from parsing hosts

How was it tested?

DEVBOX_SEARCH_HOST=foo devbox search hello

@hezhizhen hezhizhen marked this pull request as ready for review June 17, 2023 09:34
@hezhizhen hezhizhen mentioned this pull request Jun 17, 2023
Merged
@hezhizhen
Copy link
Contributor Author

@savil

savil
savil approved these changes Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@savil savil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@savil savil merged commit abc5de8 into jetify-com:main Jun 27, 2023
@hezhizhen hezhizhen deleted the searchoption branch August 9, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savil savil savil approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hezhizhen @savil