(cli) Don't check version when updating devbox #1194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me, not sure why there's the extra |
mauricioabreu
force-pushed
the
update-command-without-version-check
branch
from
4c25da5 to
186c94c
Compare
|
@Lagoja good catch! Removed |
mauricioabreu
force-pushed
the
update-command-without-version-check
branch
from
186c94c to
e10b055
Compare
Lagoja
approved these changes
Jun 24, 2023
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I don't think it is necessary to warn users about a fresh new version if they are updating devbox
How was it tested?
go run main.go update