Skip to content

Update Contribution Guide To Help Solve Potential Setup Error #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

ivorytoast
Copy link
Contributor

@ivorytoast ivorytoast commented Jun 28, 2023

Summary

When I was following the contribution guide, all the steps worked except:

Tip: you can also start VSCode from inside your Devbox shell with devbox run code.

I was getting an error stating the command code was not found. I checked the file devbox run code was running, which is .devbox/gen/scripts/code.sh. In the file (line 3), it tries to run code . -> which only works if you have installed the Visual Studio shell command.

How was it tested?

Steps I took:

  1. I could not run the command successfully without installing the Visual Studio shell command.
  2. I installed the shell command.
  3. The command ran successfully.

Why Is It Useful?

This is useful for developers who do not use Visual Studio Code as their primary IDE, therefore increasing the chances encountering an error on the beginning setup steps

@Lagoja
Copy link
Contributor

Lagoja commented Jun 28, 2023

Thanks @ivorytoast, this is a really helpful addition to the docs!

@savil savil merged commit 22cfdc3 into jetify-com:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants