Skip to content

[services] Fix process-compose not being installed #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2023
Merged

[services] Fix process-compose not being installed #1323

merged 1 commit into from
Jul 27, 2023

Conversation

mikeland73
Copy link
Contributor

Summary

On new devbox/nix installations, nix is not in PATH. For most commands, we add nix to path (add, shell, run, etc), but not for services.

Longer term, we probably don't want this if we want to support non-nix package services.

How was it tested?

In fresh docker ubuntu, ran:

devbox init
devbox services ls
devbox add apache
devbox services up

@mikeland73 mikeland73 requested review from savil and Lagoja July 27, 2023 19:02
@mikeland73 mikeland73 merged commit 80c12e0 into main Jul 27, 2023
@mikeland73 mikeland73 deleted the landau/fix-process-compose branch July 27, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lagoja Lagoja Lagoja approved these changes

@savil savil Awaiting requested review from savil

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeland73 @Lagoja