-
Notifications
You must be signed in to change notification settings - Fork 249
[per-OS Packages] Suggest --platform/--exclude-platform upon error with installing package that is uninstallable on user's platform #1364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 10, 2023
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
4af863e
to
d9e54f0
Compare
Gonna make two fixes:
|
mikeland73
approved these changes
Aug 11, 2023
f65133a
to
8790b47
Compare
c15183c
to
5191dfb
Compare
8790b47
to
1453300
Compare
5191dfb
to
f69b9f3
Compare
1453300
to
af97428
Compare
f69b9f3
to
b54fd8e
Compare
af97428
to
d8304fd
Compare
b54fd8e
to
7866592
Compare
d8304fd
to
196a1ce
Compare
7866592
to
19fb40c
Compare
196a1ce
to
7e1277e
Compare
e216027
to
e5d2bfa
Compare
e0f4a8b
to
a9bec28
Compare
e5d2bfa
to
3fc324b
Compare
a9bec28
to
fe32133
Compare
3fc324b
to
4037aa2
Compare
…th installing package that is uninstallable on user's platform
4037aa2
to
fc76ec0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes the error message to suggest using
--platform/--exclude-platform
withdevbox add
.I wish we had a way to recommend the platforms that are supported for the exact package being installed, but we don't.
The heavy lifting for this was done in #1279. Thanks @mikeland73!
How was it tested?