Skip to content

[per-OS Packages] Suggest --platform/--exclude-platform upon error with installing package that is uninstallable on user's platform #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2023

Conversation

savil
Copy link
Collaborator

@savil savil commented Aug 10, 2023

Summary

Changes the error message to suggest using --platform/--exclude-platform with devbox add.

I wish we had a way to recommend the platforms that are supported for the exact package being installed, but we don't.

The heavy lifting for this was done in #1279. Thanks @mikeland73!

How was it tested?

> devbox add glibcLocales

Installing package: glibcLocales.


Error: package glibcLocales cannot be installed on your platform x86_64-darwin. Consider using `--platform` or `--exclude-platform` with `devbox add` to install on a supported platform. Other available platforms are: aarch64-darwin, aarch64-linux, i686-linux, x86_64-linux, armv7l-linux.
Screenshot 2023-08-10 at 4 20 18 PM

@savil savil force-pushed the savil/config-packages-4 branch from 4af863e to d9e54f0 Compare August 10, 2023 23:20
@savil savil requested review from mikeland73 and gcurtis August 10, 2023 23:20
@savil savil marked this pull request as draft August 11, 2023 17:15
@savil
Copy link
Collaborator Author

savil commented Aug 11, 2023

Gonna make two fixes:

  1. Simplify the error message
  2. Ensure we can do devbox add <package> --exclude-platform <platform> even if the package exists in the devbox.json

@savil savil marked this pull request as ready for review August 11, 2023 19:46
@savil savil changed the title [Config Packages] Suggest --platform/--exclude-platform upon error with installing package that is uninstallable on user's platform [per-OS Packages] Suggest --platform/--exclude-platform upon error with installing package that is uninstallable on user's platform Aug 11, 2023
@savil savil force-pushed the savil/config-packages-3 branch from f65133a to 8790b47 Compare August 11, 2023 22:18
@savil savil force-pushed the savil/config-packages-4 branch from c15183c to 5191dfb Compare August 11, 2023 22:18
@savil savil force-pushed the savil/config-packages-3 branch from 8790b47 to 1453300 Compare August 11, 2023 22:36
@savil savil force-pushed the savil/config-packages-4 branch from 5191dfb to f69b9f3 Compare August 11, 2023 22:36
@savil savil force-pushed the savil/config-packages-3 branch from 1453300 to af97428 Compare August 11, 2023 22:46
@savil savil force-pushed the savil/config-packages-4 branch from f69b9f3 to b54fd8e Compare August 11, 2023 22:47
@savil savil force-pushed the savil/config-packages-3 branch from af97428 to d8304fd Compare August 11, 2023 23:05
@savil savil force-pushed the savil/config-packages-4 branch from b54fd8e to 7866592 Compare August 11, 2023 23:06
@savil savil force-pushed the savil/config-packages-3 branch from d8304fd to 196a1ce Compare August 11, 2023 23:09
@savil savil force-pushed the savil/config-packages-4 branch from 7866592 to 19fb40c Compare August 11, 2023 23:09
@savil savil force-pushed the savil/config-packages-3 branch from 196a1ce to 7e1277e Compare August 11, 2023 23:15
@savil savil force-pushed the savil/config-packages-4 branch 3 times, most recently from e216027 to e5d2bfa Compare August 12, 2023 00:03
@savil savil force-pushed the savil/config-packages-3 branch from e0f4a8b to a9bec28 Compare August 12, 2023 00:05
@savil savil force-pushed the savil/config-packages-4 branch from e5d2bfa to 3fc324b Compare August 12, 2023 00:05
@savil savil force-pushed the savil/config-packages-3 branch from a9bec28 to fe32133 Compare August 12, 2023 00:29
@savil savil force-pushed the savil/config-packages-4 branch from 3fc324b to 4037aa2 Compare August 12, 2023 00:29
Base automatically changed from savil/config-packages-3 to main August 12, 2023 00:29
savil added 2 commits August 11, 2023 17:30
@savil savil force-pushed the savil/config-packages-4 branch from 4037aa2 to fc76ec0 Compare August 12, 2023 00:30
@savil savil merged commit 61903ef into main Aug 12, 2023
@savil savil deleted the savil/config-packages-4 branch August 12, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants