Skip to content

[per-OS Packages] omitempty for version in expanded Package json representation #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

savil
Copy link
Collaborator

@savil savil commented Aug 31, 2023

Summary

Discussing with @Lagoja, we felt that we can omit the version string if its empty

How was it tested?

devbox add github:F1bonacc1/process-compose --exclude-platform x86_64-darwin:

BEFORE:

{
  "packages": {
    "github:F1bonacc1/process-compose/v0.40.2": {
      "version": "",
      "excluded_platforms": [
        "x86_64-darwin"
      ]
    }
  },
  ...
}

AFTER:

{
  "packages": {
    "github:F1bonacc1/process-compose/v0.40.2": {
      "excluded_platforms": [
        "x86_64-darwin"
      ]
    }
  },
  ...
}

Copy link
Collaborator Author

savil commented Aug 31, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@savil savil requested review from gcurtis, mikeland73 and Lagoja August 31, 2023 23:32
@savil savil merged commit fee697b into main Aug 31, 2023
@savil savil deleted the savil/version-omit-empty branch August 31, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants