Update docker-image-release.yml to support ARM builds for newer Macbooks #1455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evan <[email protected]>
mohsenari
approved these changes
Sep 13, 2023
|
@eljohnson92 I'm going to merge this and publish a new docker image to docker hub. Once done I'll ping you here. Please test it and see if it works for you. |
|
@eljohnson92 I just published the jetpackio/devbox image in dockerhub. It now shows support for both linux/amd64 and linux/arm64 support. Please give it a try and let me know if your issue is resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add arm64 builds to the non-root image build(currently the root image cannot be built because of #1444)
How was it tested?
I have tested this locally and confirmed the non-root image is built successfully with this change