[global] Fix global services #1484
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cobra doesn't chain
PersistentPreRunE
. So if a parent declares one and a child declares it as well, the parent function is ignored.global
usesPersistentPreRunE
to set the global project directory. Theservices
command was running it to ensure nix is installed. The child replaced the parent, so we were never setting thThe fix here is a bit ugly but it solves them problem.
There's a UX issue I rediscovered while testing this. When adding global packages the environment is not automatically refreshed. This means services wont work until a new shell is opened or if the user does
eval "$(devbox global shellenv)"
manually.How was it tested?