[plugins] Fix init hooks for custom plugins #1500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savil
approved these changes
Sep 22, 2023
examples/plugins/local/test.sh
Outdated
| echo "MY_INIT_HOOK_VAR environment variable is not set." | ||
| exit 1 | ||
| else | ||
| echo "MY_INIT_HOOK_VAR is set to '$MY_INIT_HOOK_VAR'" |
There was a problem hiding this comment.
nit: fix indent. Same for line 7
savil
reviewed
Sep 22, 2023
| pluginHooks, err := plugin.InitHooks(devbox.InstallablePackages(), devbox.ProjectDir()) | ||
| pluginHooks, err := devbox.PluginManager().InitHooks( | ||
| devbox.InstallablePackages(), | ||
| devbox.Config().Include, |
There was a problem hiding this comment.
nit: should this field be plural: Includes?
There was a problem hiding this comment.
I think this ship has sailed, has been in the devbox.json for a while now.
FWIW, I think we chatted about this an decided to use as a verb instead of noun (similar to import instead of imports). I don't feel super strongly, but it seems like it would be difficult to change (but I guess we could support both)
There was a problem hiding this comment.
oh yeah, I do remember chatting about it being a verb...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure custom plugin init hooks run. Previously they were only running for builtins.
How was it tested?
devbox run run_test