Skip to content

add fields, restrict additional props #1624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2023
Merged

add fields, restrict additional props #1624

merged 1 commit into from
Nov 13, 2023

Conversation

Lagoja
Copy link
Contributor

@Lagoja Lagoja commented Nov 13, 2023

Summary

Adds missing fields to the json schema
Restricts additional properties -- this ensures that developers can't put init_hook in the wrong location

How was it tested?

Manually using the root devbox.json

@Lagoja Lagoja requested a review from mohsenari November 13, 2023 23:31
@mohsenari
Copy link
Collaborator

thanks! let's ship it

@Lagoja Lagoja merged commit a6e5c18 into main Nov 13, 2023
@Lagoja Lagoja deleted the jl/update-schema branch November 13, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohsenari mohsenari mohsenari approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lagoja @mohsenari