[envsec] Add (hidden) envsec init command #1678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savil
approved these changes
Dec 8, 2023
internal/boxcli/envsec.go
Outdated
Comment on lines
52
to
57
| box.Config().SetStringField("EnvFrom", "envsec") | ||
| if err := box.Config().SaveTo(box.ProjectDir()); err != nil { | ||
| return errors.WithStack(err) | ||
| } | ||
|
|
||
| return envsec.EnsureInitialized(cmd.Context(), box.ProjectDir()) |
There was a problem hiding this comment.
can we swap the order of envsec.EnsureInitialized and modifying the devbox.json?
i.e. I feel we should only modify the devbox.json once we know envsec has been properly initialized.
internal/devconfig/env.go
Outdated
| @@ -18,7 +18,8 @@ func (c *Config) ComputedEnv( | |||
| if c.IsEnvsecEnabled() { | |||
| env, err = envsec.Env(ctx, projectDir) | |||
| if err != nil { | |||
| fmt.Fprintf(os.Stderr, "Error reading secrets from envsec: %s\n\n", err) | |||
| ux.Ferror(os.Stderr, "Error reading secrets from envsec: %s\n\n", err) | |||
There was a problem hiding this comment.
Given that we are continuing on, should this be a ux.Fwarning instead?
There was a problem hiding this comment.
i.e. something like:
ux.Fwarning(os.Stderr, "Computing Devbox environment without envsec secrets. There was an error from envsec: %s\n\n", err)
There was a problem hiding this comment.
I'll can switch to warning. My motivation is that it's a fairly big error (not really a warning) so I wanted to make sure it's clear. But generally we don't use errors for commands that end in success.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TSIA
How was it tested?
devbox envsec init