[nix] ensure nix is installed for generate and envsec commands #1710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savil
approved these changes
Jan 10, 2024
| } | ||
|
|
||
| // We return a closure to avoid printing the warning every time and just | ||
| // printing it if we actually need the value of the flag. | ||
| // | ||
| // TODO: devbox.Open should run nix.EnsureNixInstalled and do this logic |
There was a problem hiding this comment.
see the PR I had shared for when I reverted this change .
To make it happen, we'll need to audit many callsites and ensure scenarios like devbox version don't end up invoking devbox.Open
from the PR, here are the callsites for devbox version that led to devbox.Open being called: https://gist.github.com/savil/0fff37124abae3d1c0088404c05a73cc
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TSIA
How was it tested?
ran
generate,envseccommands and it worked as expected.Tested version check by temporarily requiring minimum version above mine.