Skip to content

[gen-readme] Improve gen readme #1735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2024
Merged

[gen-readme] Improve gen readme #1735

merged 1 commit into from
Jan 24, 2024

Conversation

mikeland73
Copy link
Contributor

@mikeland73 mikeland73 commented Jan 19, 2024

Summary

Improve automatically generated readme. Highlights:

  • Adds "getting started" section.
  • documents how to install devbox, start shell, run script
  • Adds more context around scripts, init hook.
  • Adds link to devbox repo.
  • Adds more spacing between script details

What it looks like: https://github.com/jetpack-io/devbox/blob/56e7427a8f3da266d2f3d2b4a5028a7c7a017fc3/devbox.md

How was it tested?

devbox gen readme devbox.md

@mikeland73 mikeland73 requested review from Lagoja, loreto and savil January 19, 2024 07:32
Start the devbox shell:
```sh
devbox shell
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT about nudging people towards using direnv as well? It tends to be significantly faster than starting a devbox shell (since we don't start a new shell process)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels weird to me since I personally don't use it (I tend to use devbox run a lot which is faster than shell).

Feels a bit prescriptive no? i.e. devbox is absolutely needed to develop on this repo, but direnv is more a matter of opinion?

Anyway, a follow up to this could be to allow people to specify their own readme templates so they can modify as needed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its just sooo much faster

@mikeland73 mikeland73 merged commit 4a49a04 into main Jan 24, 2024
@mikeland73 mikeland73 deleted the landau/improve-gen-readme branch January 24, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants