Backport: Remove fromcanonical in points for BivariateSpace (JuliaApproximation#604)

Author: jishnub

Project.toml

@@ -1,6 +1,6 @@
 name = "ApproxFunBase"
 uuid = "fbd15aa5-315a-5a7d-a8a4-24992e37be05"
-version = "0.8.59"
+version = "0.8.60"
 
 [deps]
 AbstractFFTs = "621f4979-c628-5d54-868e-fcf4e3e8185c"

src/Multivariate/TensorSpace.jl

@@ -570,10 +570,20 @@ end
 points(d::Union{EuclideanDomain{2},BivariateSpace},n,m) = points(d,n,m,1),points(d,n,m,2)
 
 function points(d::BivariateSpace,n,m,k)
-    ptsx=points(columnspace(d,1),n)
-    ptst=points(factor(d,2),m)
+    k ∈ (1,2) || throw(ArgumentError("k must be 1 or 2"))
 
-    promote_type(eltype(ptsx),eltype(ptst))[fromcanonical(d,x,t)[k] for x in ptsx, t in ptst]
+    ptsx = points(columnspace(d,1), n)
+    ptst = points(factor(d,2), m)
+
+    T = promote_eltypeof(ptsx, ptst)
+
+    A = if k == 1
+        repeat(ptsx, 1, m)
+    else # k == 2
+        repeat(reshape(ptst, 1, m), n)
+    end
+
+    convert(AbstractArray{T}, A)
 end
 
 

test/SpacesTest.jl

@@ -295,6 +295,13 @@ using LinearAlgebra
             @test a == a
             @test a != b
         end
+
+        @testset "points" begin
+            S = PointSpace(1:4) ⊗ PointSpace(1:4)
+            P = points(S, 4, 4)
+            @test P[1] == repeat(1:4, 1, 4)
+            @test P[2] == repeat((1:4)', 4, 1)
+        end
     end
 
     @testset "ConstantSpace" begin