Skip to content

Commit bfa7c6d

Browse files
alexey-bataevjoaosaffran
authored andcommitted
[SLP]Check if vector user exist before accessing it
Need to check if vector user exist before accessing it to avoid compiler crash. Fixes llvm#126581
1 parent 7a3f6fb commit bfa7c6d

File tree

2 files changed

+78
-2
lines changed

2 files changed

+78
-2
lines changed

llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18467,8 +18467,8 @@ void BoUpSLP::computeMinimumValueSizes() {
1846718467
any_of(
1846818468
VectorizableTree[NodeIdx]->UserTreeIndices,
1846918469
[&](const EdgeInfo &EI) {
18470-
return (EI.UserTE->hasState() &&
18471-
EI.UserTE->getOpcode() == Instruction::ICmp) &&
18470+
return EI.UserTE && EI.UserTE->hasState() &&
18471+
EI.UserTE->getOpcode() == Instruction::ICmp &&
1847218472
any_of(EI.UserTE->Scalars, [&](Value *V) {
1847318473
auto *IC = dyn_cast<ICmpInst>(V);
1847418474
return IC &&
Lines changed: 76 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 5
2+
; RUN: opt -S --passes=slp-vectorizer -mtriple=riscv64-unknown-linux-gnu -mattr=+v < %s | FileCheck %s
3+
4+
@r = external global [8 x i8]
5+
6+
define void @test(i64 %0, ptr %1) {
7+
; CHECK-LABEL: define void @test(
8+
; CHECK-SAME: i64 [[TMP0:%.*]], ptr [[TMP1:%.*]]) #[[ATTR0:[0-9]+]] {
9+
; CHECK-NEXT: [[TMP3:%.*]] = load i8, ptr @r, align 1
10+
; CHECK-NEXT: [[TMP4:%.*]] = trunc i8 [[TMP3]] to i1
11+
; CHECK-NEXT: [[TMP5:%.*]] = select i1 [[TMP4]], i64 [[TMP0]], i64 0
12+
; CHECK-NEXT: [[TMP6:%.*]] = getelementptr i8, ptr @r, i64 [[TMP5]]
13+
; CHECK-NEXT: [[TMP7:%.*]] = load i8, ptr [[TMP6]], align 1
14+
; CHECK-NEXT: [[TMP8:%.*]] = icmp ule i8 [[TMP3]], [[TMP7]]
15+
; CHECK-NEXT: [[TMP9:%.*]] = sext i1 [[TMP8]] to i32
16+
; CHECK-NEXT: [[TMP10:%.*]] = load i8, ptr getelementptr (i8, ptr @r, i64 -8049), align 1
17+
; CHECK-NEXT: [[TMP11:%.*]] = trunc i8 [[TMP10]] to i1
18+
; CHECK-NEXT: [[TMP12:%.*]] = select i1 [[TMP11]], i64 [[TMP0]], i64 0
19+
; CHECK-NEXT: [[TMP13:%.*]] = getelementptr i8, ptr @r, i64 [[TMP12]]
20+
; CHECK-NEXT: [[TMP14:%.*]] = load i8, ptr [[TMP13]], align 1
21+
; CHECK-NEXT: [[TMP15:%.*]] = icmp ule i8 [[TMP10]], [[TMP14]]
22+
; CHECK-NEXT: [[TMP16:%.*]] = sext i1 [[TMP15]] to i32
23+
; CHECK-NEXT: [[TMP17:%.*]] = add i32 [[TMP9]], [[TMP16]]
24+
; CHECK-NEXT: [[TMP18:%.*]] = load i8, ptr getelementptr (i8, ptr @r, i64 -16098), align 1
25+
; CHECK-NEXT: [[TMP19:%.*]] = trunc i8 [[TMP18]] to i1
26+
; CHECK-NEXT: [[TMP20:%.*]] = select i1 [[TMP19]], i64 [[TMP0]], i64 0
27+
; CHECK-NEXT: [[TMP21:%.*]] = getelementptr i8, ptr @r, i64 [[TMP20]]
28+
; CHECK-NEXT: [[TMP22:%.*]] = load i8, ptr [[TMP21]], align 1
29+
; CHECK-NEXT: [[TMP23:%.*]] = icmp ule i8 [[TMP18]], [[TMP22]]
30+
; CHECK-NEXT: [[TMP24:%.*]] = sext i1 [[TMP23]] to i32
31+
; CHECK-NEXT: [[TMP25:%.*]] = add i32 [[TMP17]], [[TMP24]]
32+
; CHECK-NEXT: [[TMP26:%.*]] = load i8, ptr getelementptr (i8, ptr @r, i64 -24147), align 1
33+
; CHECK-NEXT: [[TMP27:%.*]] = trunc i8 [[TMP26]] to i1
34+
; CHECK-NEXT: [[TMP28:%.*]] = select i1 [[TMP27]], i64 [[TMP0]], i64 0
35+
; CHECK-NEXT: [[TMP29:%.*]] = getelementptr i8, ptr @r, i64 [[TMP28]]
36+
; CHECK-NEXT: [[TMP30:%.*]] = load i8, ptr [[TMP29]], align 1
37+
; CHECK-NEXT: [[TMP31:%.*]] = icmp ule i8 [[TMP26]], [[TMP30]]
38+
; CHECK-NEXT: [[TMP32:%.*]] = sext i1 [[TMP31]] to i32
39+
; CHECK-NEXT: [[TMP33:%.*]] = add i32 [[TMP25]], [[TMP32]]
40+
; CHECK-NEXT: store i32 [[TMP33]], ptr [[TMP1]], align 4
41+
; CHECK-NEXT: ret void
42+
;
43+
%3 = load i8, ptr @r, align 1
44+
%4 = trunc i8 %3 to i1
45+
%5 = select i1 %4, i64 %0, i64 0
46+
%6 = getelementptr i8, ptr @r, i64 %5
47+
%7 = load i8, ptr %6, align 1
48+
%8 = icmp ule i8 %3, %7
49+
%9 = sext i1 %8 to i32
50+
%10 = load i8, ptr getelementptr (i8, ptr @r, i64 -8049), align 1
51+
%11 = trunc i8 %10 to i1
52+
%12 = select i1 %11, i64 %0, i64 0
53+
%13 = getelementptr i8, ptr @r, i64 %12
54+
%14 = load i8, ptr %13, align 1
55+
%15 = icmp ule i8 %10, %14
56+
%16 = sext i1 %15 to i32
57+
%17 = add i32 %9, %16
58+
%18 = load i8, ptr getelementptr (i8, ptr @r, i64 -16098), align 1
59+
%19 = trunc i8 %18 to i1
60+
%20 = select i1 %19, i64 %0, i64 0
61+
%21 = getelementptr i8, ptr @r, i64 %20
62+
%22 = load i8, ptr %21, align 1
63+
%23 = icmp ule i8 %18, %22
64+
%24 = sext i1 %23 to i32
65+
%25 = add i32 %17, %24
66+
%26 = load i8, ptr getelementptr (i8, ptr @r, i64 -24147), align 1
67+
%27 = trunc i8 %26 to i1
68+
%28 = select i1 %27, i64 %0, i64 0
69+
%29 = getelementptr i8, ptr @r, i64 %28
70+
%30 = load i8, ptr %29, align 1
71+
%31 = icmp ule i8 %26, %30
72+
%32 = sext i1 %31 to i32
73+
%33 = add i32 %25, %32
74+
store i32 %33, ptr %1, align 4
75+
ret void
76+
}

0 commit comments

Comments
 (0)