Skip to content

Commit d2357cb

Browse files
opacamjoergbrech
authored andcommitted
[NDK19] Remove --sysroot from LDFLAGS for cffi and pymunk (kivy#1965)
Because `--sysroot` flag is not needed anymore and make it fails the build since we migrated to new android's build system (implemented in NDK r19) See also: - https://developer.android.com/ndk/guides/other_build_systems
1 parent 6ea3d19 commit d2357cb

File tree

2 files changed

+0
-2
lines changed

2 files changed

+0
-2
lines changed

pythonforandroid/recipes/cffi/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ def get_recipe_env(self, arch=None):
3838
ndk_dir = self.ctx.ndk_platform
3939
ndk_lib_dir = os.path.join(ndk_dir, 'usr', 'lib')
4040
env['LDFLAGS'] += ' -L{}'.format(ndk_lib_dir)
41-
env['LDFLAGS'] += " --sysroot={}".format(self.ctx.ndk_platform)
4241
env['PYTHONPATH'] = ':'.join([
4342
self.ctx.get_site_packages_dir(),
4443
env['BUILDLIB_PATH'],

pythonforandroid/recipes/pymunk/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ def get_recipe_env(self, arch):
1414
env['PYTHON_ROOT'] = self.ctx.get_python_install_dir()
1515
env['LDFLAGS'] += " -shared -llog"
1616
env['LDFLAGS'] += ' -L{}'.format(join(self.ctx.ndk_platform, 'usr', 'lib'))
17-
env['LDFLAGS'] += " --sysroot={}".format(self.ctx.ndk_platform)
1817
env['LIBS'] = env.get('LIBS', '') + ' -landroid'
1918
return env
2019

0 commit comments

Comments
 (0)