chore: remove queryDirty

Author: johnsoncodehk

packages/reactivity/src/computed.ts

@@ -49,10 +49,6 @@ export class ComputedRefImpl<T> {
     this[ReactiveFlags.IS_READONLY] = isReadonly
   }
 
-  queryDirty() {
-    return this.value
-  }
-
   get value() {
     // the computed ref may get wrapped by other proxies e.g. readonly() #3376
     const self = toRaw(this)

packages/reactivity/src/dep.ts

@@ -1,11 +1,12 @@
-import { ReactiveEffect } from './effect'
+import type { ReactiveEffect } from './effect'
+import type { ComputedRefImpl } from './computed'
 
 export type Dep = Map<ReactiveEffect, number> & {
-  queryDirty?: () => void
+  computed?: ComputedRefImpl<any>
 }
 
-export const createDep = (queryDirty?: () => void): Dep => {
+export const createDep = (computed?: ComputedRefImpl<any>): Dep => {
   const dep: Dep = new Map()
-  dep.queryDirty = queryDirty
+  dep.computed = computed
   return dep
 }

packages/reactivity/src/effect.ts

@@ -74,9 +74,11 @@ export class ReactiveEffect<T = any> {
       this._queryingDirty = true
       pauseTracking()
       for (const dep of this.deps) {
-        dep.queryDirty?.()
-        if (this._dirtyLevel >= DirtyLevels.ComputedValueDirty) {
-          break
+        if (dep.computed) {
+          triggerComputed(dep.computed)
+          if (this._dirtyLevel >= DirtyLevels.ComputedValueDirty) {
+            break
+          }
         }
       }
       resetTracking()
@@ -120,6 +122,10 @@ export class ReactiveEffect<T = any> {
   }
 }
 
+function triggerComputed(computed: ComputedRefImpl<any>) {
+  return computed.value
+}
+
 function cleanupEffect(effect: ReactiveEffect) {
   effect._trackId++
   effect._depsLength = 0

packages/reactivity/src/ref.ts

@@ -46,9 +46,7 @@ export function trackRefValue(ref: RefBase<any>) {
         activeEffect,
         ref.dep ||
           (ref.dep = createDep(
-            ref instanceof ComputedRefImpl
-              ? ref.queryDirty.bind(ref)
-              : undefined
+            ref instanceof ComputedRefImpl ? ref : undefined
           )),
         {
           target: ref,
@@ -61,9 +59,7 @@ export function trackRefValue(ref: RefBase<any>) {
         activeEffect,
         ref.dep ||
           (ref.dep = createDep(
-            ref instanceof ComputedRefImpl
-              ? ref.queryDirty.bind(ref)
-              : undefined
+            ref instanceof ComputedRefImpl ? ref : undefined
           ))
       )
     }