getcov: Add -x arg for generating Cobertura XML. Lean toward style guide.

Author: jonreid

README.md

@@ -1,6 +1,6 @@
 ![XcodeCoverage](http://qualitycoding.org/jrwp/wp-content/uploads/2014/03/XcodeCoverage.png)
 
-These scripts provide a simple way to generate HTML reports of the code coverage of your Xcode project.  
+These scripts provide a simple way to generate HTML reports of the code coverage of your Xcode project.
 
 
 Xcode Project Setup

getcov

@@ -3,21 +3,29 @@
 #   Copyright 2014 Jonathan M. Reid. See LICENSE.txt
 
 usage() {
-  echo "usage: getcov [[[-o output_directory] [-i info_file] [-v]] | [-h]]"
+  echo "usage: getcov [[-s] [-x] [-o output_dir] [-i info_file] [-v]] | [-h]]"
 }
 
 main() {
   scripts="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
   source "${scripts}/envcov.sh"
 
   LCOV_INFO=Coverage.info
-  OUT_DIR="${BUILT_PRODUCTS_DIR}"
+  output_dir="${BUILT_PRODUCTS_DIR}"
   while [ "$1" != "" ]; do
     case $1 in
+      -s|--show)
+        show_html=1
+        echo "Show HTML Report"
+        ;;
+      -x|--xml)
+        generate_xml=1
+        echo "Generate Cobertura XML"
+        ;;
       -o)
         shift
-        OUT_DIR=$1
-        echo "OUT_DIR = ${OUT_DIR}"
+        output_dir=$1
+        echo "output_dir = ${output_dir}"
         ;;
       -i)
         shift
@@ -28,10 +36,6 @@ main() {
         verbose=1
         echo "Verbose"
         ;;
-      -s|--show)
-        show_report=1
-        echo "Show Report"
-        ;;
       -h|--help)
         usage
         echo "Show Help"
@@ -52,39 +56,43 @@ main() {
   enter_lcov_dir
   gather_coverage
   exclude_data
-  generate_cobertura_xml
+
+  if [ "$generate_xml" = "1" ]; then
+    generate_cobertura_xml
+  fi
+
   generate_html_report
 
-  if [ "$show_report" = "1" ]; then
+  if [ "$show_html" = "1" ]; then
     show_html_report
   fi
 }
 
 report_values() {
   echo "XcodeCoverage: Environment"
-  echo "scripts   : ${scripts}"
-  echo "LCOV_INFO : ${LCOV_INFO}"
-  echo "BUILD_DIR : ${BUILT_PRODUCTS_DIR}"
-  echo "SRCROOT   : ${SRCROOT}"
-  echo "OBJ_DIR   : ${OBJ_DIR}"
-  echo "LCOV_PATH : ${LCOV_PATH}"
-  echo "OUT_DIR   : ${OUT_DIR}"
+  echo "scripts    : ${scripts}"
+  echo "output_dir : ${output_dir}"
+  echo "LCOV_INFO  : ${LCOV_INFO}"
+  echo "BUILD_DIR  : ${BUILT_PRODUCTS_DIR}"
+  echo "SRCROOT    : ${SRCROOT}"
+  echo "OBJ_DIR    : ${OBJ_DIR}"
+  echo "LCOV_PATH  : ${LCOV_PATH}"
 }
 
 remove_old_report() {
   if [ "$verbose" = "1" ]; then
     echo "XcodeCoverage: Removing old report"
   fi
 
-  pushd "${OUT_DIR}"
+  pushd "${output_dir}"
   if [ -e lcov ]; then
     rm -r lcov
   fi
   popd
 }
 
 enter_lcov_dir() {
-  cd "${OUT_DIR}"
+  cd "${output_dir}"
   mkdir lcov
   cd lcov
 }